Hi Monty (2010.12.13_04:59:51_+0200)
> In any case- if you can upload to debian for me, that'd be swell. (And
> then I'm going to go back and re-org upstream code so that this all
> works better - this was definitely caused by a baroque source code
> arrangement, actually)
Hi, I'm afraid I'm not a DD (in the NM process...) so I can't upload to
Debian for you. I can upload it to Ubuntu, but so can you :)
This package has DPMT in uploaders, so you should easily be able to find
a sponsor there (assuming your previous sponsor isn't available).
However, DPMT packages usually live in DPMT svn, so you may need to
rehome your packaging there to get DPMT sponsors to look at it.
If I can offer some review:
1. No need to BD on python-support any more, you are using dh_python2.
2. pycompat is deprecated and serves no purpose.
3. Instead of using pyversions, use X-Python-Version and
X-Python3-Version (requires a build-dep on python-all )>= 2.6.5-13~)
4. Instead of py[3]versions -sv, use -rv, which is the intersection
between supported and requested versions.
6. You can do "dh $@ --with python2,python3"
7. When you have muliple shell commands in a make rule line, you should
start it with set -e, otherwise build failures will be ignored
8. When you use uscan in rules, you should use --noconf, and --destdir
should be .
10. It looks like the test suite needs a drizzle server. I don't know
how you can get that to work sanely :/
Also, instead of overriding dh_build there, you should probably do
dh_auto_build, and check for nocheck in DEB_BULID_OPTIONS.
Then run the test suite on every build{,3}vers{,-dbg}.
11. lib/drizzle/libdrizzle.py seems to get modified during build.
12. I can't see setuptools being used, don't know why it's in BD.
13. It can build for Python 2.5 (dunno if it'll pass tests) if you
import future with_statement in setup.py.
14. Can I suggest the following alternative to your
dh_build, dh_install and dh_installdeb:
|override_dh_auto_build:
| set -e; \
| for i in $(buildvers) $(build3vers); do \
| python$$i setup.py build; \
| python$$i-dbg setup.py build; \
| done
|
|override_dh_auto_install:
| set -e; \
| for i in $(buildvers); do \
| python$$i setup.py install --skip-build --root
$(CURDIR)/debian/python-drizzle --install-layout=deb; \
| python$$i-dbg setup.py install --skip-build --root
$(CURDIR)/debian/python-drizzle --install-layout=deb; \
| done
| set -e; \
| for i in $(build3vers); do \
| python$$i setup.py install --skip-build --root
$(CURDIR)/debian/python3-drizzle --install-layout=deb; \
| python$$i-dbg setup.py install --skip-build --root
$(CURDIR)/debian/python3-drizzle --install-layout=deb; \
| done
|
|override_dh_strip:
|ifeq (,$(filter nostrip,$(DEB_BUILD_OPTIONS)))
| dh_strip -ppython-drizzle --dbg-package=python-drizzle-dbg
| dh_strip -ppython3-drizzle --dbg-package=python3-drizzle-dbg
|endif
|
|override_dh_installdocs:
| dh_installdocs -ppython-drizzle -ppython-drizzle-dbg
--link-doc=python-drizzle
| dh_installdocs -ppython3-drizzle -ppython3-drizzle-dbg
--link-doc=python3-drizzle
SR
--
Stefano Rivera
http://tumbleweed.org.za/
H: +27 21 465 6908 C: +27 72 419 8559 UCT: x3127
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
