On Sun, 19 Dec 2010 at 13:59:51 +0000, brian m. carlson wrote:
> I've looked at the provided patch, and I don't think it's correct.
I agree with your assessment.
> The right way to fix this is to find out why HAVE_VSSCANF is not be
> defined properly.
The answer turns out to be "because nobody asked for it" - it'd normally
be defined by using AC_CHECK_FUNCS([vsscanf]) in configure.ac, but that
check hasn't actually been added.
For a minimal fix suitable for squeeze, we could just define it
unconditionally; see attached. This compiles (in an i386 chroot where I can
also reproduce the failure to build without the patch); I haven't checked
whether the resulting binaries work.
I do wonder whether the package should be removed, though: it's dead upstream,
only works on i386 to load non-free Windows codecs, and the former upstream
developer now works on open-source implementations of the same codecs in
ffmpeg.
Simon
>From 3bab3846cfe1e047090a12d8b4e181133c4b9b6b Mon Sep 17 00:00:00 2001
From: Simon McVittie <s...@debian.org>
Date: Wed, 22 Dec 2010 22:15:19 +0000
Subject: [PATCH] Define HAVE_VSSCANF in CPPFLAGS to avoid FTBFS with recent gcc versions
The correct fix would be to add AC_CHECK_FUNCS([vsscanf]) to configure.ac,
but that needs an autoreconf and a correspondingly larger diff.
---
debian/changelog | 9 +++++++++
debian/rules | 2 ++
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index a23047f..de4390c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+gstreamer0.10-pitfdll (0.9.1.1+cvs20080215-1.1) UNRELEASED; urgency=low
+
+ * Non-maintainer upload.
+ * Define HAVE_VSSCANF in CPPFLAGS to avoid FTBFS with recent gcc versions;
+ the correct fix would be to add AC_CHECK_FUNCS([vsscanf]) to configure.ac,
+ but that needs an autoreconf and a correspondingly larger diff.
+
+ -- Simon McVittie <s...@debian.org> Wed, 22 Dec 2010 22:02:08 +0000
+
gstreamer0.10-pitfdll (0.9.1.1+cvs20080215-1) unstable; urgency=low
* New CVS snapshot:
diff --git a/debian/rules b/debian/rules
index a3b017d..5a6d0cb 100755
--- a/debian/rules
+++ b/debian/rules
@@ -5,6 +5,8 @@ include /usr/share/cdbs/1/rules/simple-patchsys.mk
include /usr/share/cdbs/1/class/gnome.mk
DEB_CONFIGURE_EXTRA_FLAGS := --with-dlldir=/usr/lib/codecs --disable-static
+# a quick autoreconf-less workaround for http://bugs.debian.org/558703
+CPPFLAGS += -DHAVE_VSSCANF
install/gstreamer0.10-pitfdll::
rm -f debian/gstreamer0.10-pitfdll/usr/lib/gstreamer-0.10/libpitfdll.*a
--
1.7.2.3
