Package: munin-node
Version: 1.4.5-3
Severity: normal
Tags: upstream patch
Running munin-node-configure --shell generates an error:
$ sudo /usr/sbin/munin-node-configure --shell
ln -s '/usr/share/munin/plugins/acpi' '/etc/munin/plugins/acpi'
ln -s '/usr/share/munin/plugins/apache_accesses'
'/etc/munin/plugins/apache_accesses'
ln -s '/usr/share/munin/plugins/apache_volume'
'/etc/munin/plugins/apache_volume'
ln -s '/usr/share/munin/plugins/diskstats' '/etc/munin/plugins/diskstats'
ln -s '/usr/share/munin/plugins/fw_conntrack' '/etc/munin/plugins/fw_conntrack'
ln -s '/usr/share/munin/plugins/fw_forwarded_local'
'/etc/munin/plugins/fw_forwarded_local'
ln -s '/usr/share/munin/plugins/fw_packets' '/etc/munin/plugins/fw_packets'
ln -s '/usr/share/munin/plugins/iostat_ios' '/etc/munin/plugins/iostat_ios'
ln -s '/usr/share/munin/plugins/lpstat' '/etc/munin/plugins/lpstat'
ln -s '/usr/share/munin/plugins/ntp_kernel_err'
'/etc/munin/plugins/ntp_kernel_err'
ln -s '/usr/share/munin/plugins/ntp_kernel_pll_freq'
'/etc/munin/plugins/ntp_kernel_pll_freq'
ln -s '/usr/share/munin/plugins/ntp_kernel_pll_off'
'/etc/munin/plugins/ntp_kernel_pll_off'
ln -s '/usr/share/munin/plugins/proc_pri' '/etc/munin/plugins/proc_pri'
ln -s '/usr/share/munin/plugins/threads' '/etc/munin/plugins/threads'
ln -s '/usr/share/munin/plugins/uptime' '/etc/munin/plugins/uptime'
ln -s '/usr/share/munin/plugins/users' '/etc/munin/plugins/users'
# The following plugins caused errors:
# ip_:
# Nothing printed to stdout
# No valid suggestions
[status 1]
Since I use the output and the error code from that script, this was a
showstopper for me!
The cause is that the ip_ module is not outputting data when called
with the suggest option:
$ sudo MUNIN_LIBDIR=/usr/share/munin /usr/share/munin/plugins/ip_ suggest
$
^^^ See NO output there
This is due to a bug in the ip_ script, which I fixed with the following patch:
--- /usr/share/munin/plugins/ip_.orig 2010-10-05 09:39:09.000000000 -0400
+++ /usr/share/munin/plugins/ip_ 2011-01-01 12:46:04.000000000 -0500
@@ -136,7 +136,7 @@
fi
if [ "$1" = "suggest" ]; then
- iptables -L ${INPUT} -v -n -x 2>/dev/null | awk --posix '$8 ~
/^([0-9]{1,3}\.){3}[0-9]{1,3}$/ { if (done[$8]!=1) {print $8; done[$8]=1;}}'
+ iptables -L ${INPUT} -v -n -x 2>/dev/null | awk --posix '$8 ~
/^([0-9]{1,3}\.){3}[0-9]{1,3}\/[0-9]{1,2}$/ {sub(/\/[0-9]{1,2}$/,"",$8); if
(done[$8]!=1) {print $8; done[$8]=1;}}'
if [ -x /sbin/ip6tables ]; then
ip6tables -L ${INPUT} -v -n -x 2>/dev/null | awk --posix '$7 ~ /\/128$/
{ if (done[$7]!=1) {a=$7;gsub(/\/128$/, "", a); print a; done[$7]=1;}}'
fi
However, bug #491475 also applies and the patch to fix it and bug #489502
appear to be incomplete. That is, that fix does not work for the ip_
module as well. So I recommend looking into making that fix work for
the ip_ plugin as well.
Finally, eyeballing the gsub two lines down for ip6tables, it solves
the same problem in a different way than I did. I like my approach
better and so I suggest these considerations for improving that line:
- use sub instead of gsub since the regex is anchored to the end of the line
- I suspect not all ipv6 netmasks end with /128, so the regex should
probably be generalized to /\/[0-9]{1,3}$/
- Logically, I prefer to fill the done array with what is printed.
Also, it seems possible that one might have multiple masks for the
same network address (though that would probably be a configuration
mistake). My approach would only output one line whereas the current
code would output two duplicate lines. That may be a clue or a bug,
I'm not sure.
- When I run ip6tables:
$ sudo ip6tables -L ${INPUT} -v -n -x
Chain INPUT (policy ACCEPT 0 packets, 0 bytes)
pkts bytes target prot opt in out source
destination
It looks like it is field 8 also. So I think the $7 should be $8.
Therefore, I suggest the following untested, unverifiable by me, fix
for the ip6tables line:
ip6tables -L ${INPUT} -v -n -x 2>/dev/null | awk --posix '$8 ~
/^([0-9]{1,3}\.){3}[0-9]{1,3}\/[0-9]{1,3}$/ {sub(/\/[0-9]{1,3}$/,"",$8); if
(done[$8]!=1) {print $8; done[$8]=1;}}'
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores)
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash
Versions of packages munin-node depends on:
ii adduser 3.112+nmu2 add and remove users and groups
ii gawk 1:3.1.7.dfsg-5 GNU awk, a pattern scanning and pr
ii libnet-server-perl 0.97-1 An extensible, general perl server
ii lsb-base 3.2-23.1 Linux Standard Base 3.2 init scrip
ii munin-common 1.4.5-3 network-wide graphing framework (c
ii perl 5.10.1-16 Larry Wall's Practical Extraction
ii procps 1:3.2.8-9 /proc file system utilities
Versions of packages munin-node recommends:
ii libnet-snmp-perl 5.2.0-4 Script SNMP connections
Versions of packages munin-node suggests:
pn acpi | lm-sensors <none> (no description available)
ii ethtool 1:2.6.34-3 display or change Ethernet device
ii hdparm 9.32-1 tune hard disk parameters for high
pn libcache-cache-perl <none> (no description available)
ii libcrypt-ssleay-perl 0.57-2 Support for https protocol in LWP
pn libdbd-mysql-perl <none> (no description available)
pn libdbd-pg-perl <none> (no description available)
pn liblwp-useragent-determ <none> (no description available)
pn libnet-irc-perl <none> (no description available)
ii libnet-ssleay-perl 1.36-1 Perl module for Secure Sockets Lay
pn libtext-csv-xs-perl <none> (no description available)
ii libwww-perl 5.836-1 Perl HTTP/WWW client/server librar
ii libxml-simple-perl 2.18-3 Perl module for reading and writin
ii logtail 1.3.13 Print log file lines that have not
pn munin <none> (no description available)
pn munin-java-plugins <none> (no description available)
pn munin-plugins-extra <none> (no description available)
pn mysql-client <none> (no description available)
ii net-tools 1.60-23 The NET-3 networking toolkit
ii python 2.6.6-3+squeeze4 interactive high-level object-orie
ii ruby 4.5 An interpreter of object-oriented
pn smartmontools <none> (no description available)
-- Configuration Files:
/etc/cron.d/munin-node changed [not included]
/etc/munin/plugin-conf.d/munin-node [Errno 13] Permission denied:
u'/etc/munin/plugin-conf.d/munin-node'
-- no debconf information
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
