severity 608336 important
retitle 608336 SPF ACL example uses removed package libmail-spf-query-perl
tags 608336 patch
thanks
On 2010-12-30 gregor herrmann <[email protected]> wrote:
> On Thu, 30 Dec 2010 19:44:06 +0100, Andreas Metzler wrote:
> > > Please adjust your Suggest to either libmail-spf-perl or
> > > spf-tools-perl.
>> A perfect followup bug to this change in 4.71-4: :-O
>
>> * Invoke spfquery as spfquery.mail-spf-query-perl. There are three
>> different
>> implementations of spfquery in Debian, with incompatible commandline
>> switches and different exit codes. Closes: #573956
> Heh :)
> > Tomorrow.
> > Is either of libmail-spf-perl/spf-tools-perl prefered or better?
> AFAIK libmail-spf-perl contains the perl modules and spf-tools-perl
> the scripts (i.e. /usr/bin/spfquery.mail-spf-perl and
> /usr/sbin/spfd.mail-spf-perl; and it depends on libmail-spf-perl).
> If I read the changelog entry above correctly, exim calls the script
> and therefore would need to Suggest spf-tools-perl.
[...]
spf-tools-perl should work. I have fixed this in SVN but will not be
able to push this to squeeze. This bug is just not release-critical.
I am attaching the patch commited to SVN for reference.
cu andreas
--- debian/debconf/conf.d/acl/30_exim4-config_check_rcpt (Revision 2529)
+++ debian/debconf/conf.d/acl/30_exim4-config_check_rcpt (Arbeitskopie)
@@ -240,8 +240,8 @@
#
# This is quite costly in terms of DNS lookups (~6 lookups per mail). Do not
# enable if that's an issue. Also note that if you enable this, you must
- # install "libmail-spf-query-perl" which provides the spfquery command.
- # Missing libmail-spf-query-perl will trigger the "Unexpected error in
+ # install "spf-tools-perl" which provides the spfquery command.
+ # Missing spf-tools-perl will trigger the "Unexpected error in
# SPF check" warning.
.ifdef CHECK_RCPT_SPF
deny
@@ -249,7 +249,7 @@
Please see http://www.openspf.org/Why?scope=${if def:sender_address_domain {mfrom}{helo}};identity=${if def:sender_address_domain {$sender_address}{$sender_helo_name}};ip=$sender_host_address
log_message = SPF check failed.
!acl = acl_local_deny_exceptions
- condition = ${run{/usr/bin/spfquery.mail-spf-query-perl --ip \"$sender_host_address\" --mail-from \"$sender_address\" --helo \"$sender_helo_name\"}\
+ condition = ${run{/usr/bin/spfquery.mail-spf-perl --ip \"$sender_host_address\" --mfrom \"$sender_address\" --helo \"$sender_helo_name\"}\
{no}{${if eq {$runrc}{1}{yes}{no}}}}
defer
@@ -265,18 +265,6 @@
warn
log_message = Unexpected error in SPF check.
condition = ${if >{$runrc}{6}{yes}{no}}
-
- # Support for best-guess (see http://www.openspf.org/developers-guide.html)
- warn
- message = X-SPF-Guess: ${run{/usr/bin/spfquery.mail-spf-query-perl --ip \"$sender_host_address\" --mail-from \"$sender_address\" \ --helo \"$sender_helo_name\" --guess true}\
- {pass}{${if eq {$runrc}{2}{softfail}{${if eq {$runrc}{3}{neutral}{${if eq {$runrc}{4}{unknown}\
- {${if eq {$runrc}{6}{none}{error}}}}}}}}}}
- condition = ${if <={$runrc}{6}{yes}{no}}
-
- defer
- message = Temporary DNS error while checking SPF record. Try again later.
- !acl = acl_local_deny_exceptions
- condition = ${if eq {$runrc}{5}{yes}{no}}
.endif
