Jan Niehusmann wrote:
> On Wed, Jul 27, 2005 at 10:52:28AM -0400, Joey Hess wrote:
> > Jan Niehusmann wrote:
> > > On Wed, Jul 27, 2005 at 09:33:04AM -0400, Joey Hess wrote:
> > > > if [ "$1" = configure ] && [ "$2" = upgrade ] && [ -L /usr/doc/tf ] && \
> > >                                ^^^^^^^^^^^^^^
> > > >    dpkg --compare-versions "$2" le "1:4.0s1-16"; then
> > >                              ^^^^ looks wrong, but I didn't check
> > >                        closely. 
> > > >         rm -f /usr/doc/tf
> > > > fi
> > > 
> > > Even with $2 used twice in a way which looks wrong to me, thanks for
> > > that code, should be easy to fix and do the right thing then.
> > 
> > First, first one should be $1
> 
> And I guess one of the && should read ||:
> 
> if [ "$1" = configure ] || [ "$1" = upgrade ] && [ -L /usr/doc/tf ] && \
>     dpkg --compare-versions "$2" le "1:4.0s1-16.1"; then
>     rm -f /usr/doc/tf
> fi      
> 
> Correct? I'm just preparing the upload.

if ( [ "$1" = configure ] || [ "$1" = upgrade ] ) && [ -L /usr/doc/tf ] && \
    dpkg --compare-versions "$2" le "1:4.0s1-16.1"; then
    rm -f /usr/doc/tf
fi      

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature

Reply via email to