Agustin Martin writes:
 > On Tue, Jan 11, 2011 at 11:25:50AM +0100, Agustin Martin wrote:
 > > On Mon, Jan 10, 2011 at 05:17:54PM -0800, Steve VanDevender wrote:
 > > > Package: dictionaries-common
 > > > Version: 1.5.16
 > > > Severity: important
 > > > Tags: squeeze
 > > > 
 > > > /usr/share/emacs/site-lisp/dictionaries-common/ispell.el creates a bogus
 > > > entry in default-menubar under XEmacs 21 (xemacs21-nomule is what I am
 > > > running).
 > > > 
 > > > After ispell.el changes the "Kill Process" menu item under Cmds ->
 > > > Spell-Check, any attempt to click on the menubar produces the error
 > > > "Wrong type argument: stringp, clear" because a symbol is not allowed as
 > > > an optional fourth item in a menu specification.  I originally
 > > > encountered this when using the VM mail reader that is part of
 > > > xemacs21-basesupport, and finding that after the first time I ran
 > > > vm-compose-mail, the menubar became unusable.  However, it seems likely
 > > > this affects other Emacs/XEmacs packages as well.
 > > 
 > > Cannot reproduce that here at all, neither with normal xemacs21 nor with
 > > xemacs21-nomule. Using XEmacs, open a file, spellcheck, kill process, no
 > > problem, menu is accesible. Am I missing something? 
 > 
 > Tried also with lenny's xemacs21 and dictionaries-common 1.5.14, that also
 > contains the change. No problem found.

Here, try this:

Install Debian packages xemacs21-nomule *or* xemacs21-mule,
xemacs21-basesupport, and ispell.

Run xemacs.

Do M-x vm-compose-mail and send a message (to yourself, /dev/null,
whatever).

Run M-x vm-compose-mail again.  If I have the right set of prerequisites
for you, the error "Wrong type argument: stringp, clear" should signal
at that point, and you should also find that any clicks on the menubar
signal the same error.  (You'll probably also notice that the
debug-on-error traceback doesn't really help pinpoint this problem.)

 > Note that this change was introduced in dictionaries-common 1.5.3, released
 > in early May. Is strange that nobody else experienced this problem before. 
 > Which XEmacs 21 version and flavour are you using? Has your system anything
 > special?

I just upgraded the system where I most heavily use XEmacs and the VM
mail reader from Debian lenny to Debian squeeze last week, so I ended up
skipping over many versions of dictionaries-common (0.98.12 was shipped
with lenny).  I've been trying to chase down the specifics of this bug
since (unfortunately the stack backtrace from debug-on-error gives no
indication of where this bug really occurred, which made it hard to
trace it to this location.  While casting around I also filed #609603
thinking it was a problem in VM and hence xemacs21-basesupport, but I
have since retracted that).

 > > > I find that the patch below fixes the issue locally (after I apply it
 > > > and recompile ispell.elc).  If adding "'clear" to the menu was meant
 > > > to accomplish something, that probably needs to be done in some more
 > > > portable way.  My testing does not suggest that the function of that
 > > > menu entry is impaired by removal of "'clear".
 > > > 
 > > > --- ispell.el.orig       2010-11-15 05:21:32.000000000 -0800
 > > > +++ ispell.el    2011-01-10 16:50:35.000000000 -0800
 > > > @@ -1352,7 +1352,7 @@
 > > >               ["Continue Check"  ispell-continue                 t]
 > > >               ["Complete Word Frag"ispell-complete-word-interior-frag t]
 > > >               ["Complete Word"   ispell-complete-word            t]
 > > > -             ["Kill Process"    ispell-kill-ispell       t 'clear]
 > > > +             ["Kill Process"    ispell-kill-ispell              t]
 > > >               ["Customize..."    (customize-group 'ispell)       t]
 > > >               ;; flyspell-mode may not be bound...
 > > >               ;;["flyspell"      flyspell-mode
 > > 
 > > This is there to clean session localwords.
 > 
 > In case a change is really needed, I'd expect something like (untested)
 > 
 >  ["Kill Process"    (ispell-kill-ispell t 'clear) t]
 > 
 > to work. But I'd like to know first what is happening.

That is probably more what you would need if you want to pass additional
arguments to ispell-kill-ispell.  Based on the definition of
ispell-kill-ispell in the ispell.el shipped with dictionaries-common it
looks like it would work.  I can give it a try on my system.

 > Thanks for your feedback,
 > 
 > -- 
 > Agustin



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to