On Tue, Jan 25, 2011 at 04:57:42PM +0200, Teodor MICU wrote: > Hi, Hello
> > 2011/1/24 Harald Jenny <har...@a-little-linux-box.at>: > > On Mon, Jan 24, 2011 at 10:40:06PM +0200, Teodor MICU wrote: > >> I can only spot some cosmetic issues, otherwise I see no problem. The > >> change USER -> SYSTEMUSER only makes the diff larger and not really > >> necessary. > > > > I tend to disagree as USER (as well as USERNAME) is set by the shell and so > > a > > [ -n "$USER" ] || USER=amavis > > check always evaluates to the user running the init script :-/ - as this is > > not > > the desired action I decided to rename USER to SYSTEMUSER (and will also > > change > > this in the config file). > > Good catch. Indeed, $USER is defined on interactive sessions and I was > only thinking about starting at boot. Yes therefor I think this change is also necessary do you agree? > > >> Ok, I see how MILTERSOCKET is used now. > > > > IMHO it's better to keep the number of command line options as short as > > possible. > > I can only agree in principle. :-) thanks > > > Well I don't think this package will make it into Debian Squeeze as for me a > > prerequisite is a fixed libmilter version... sorry when I kept you from > > doing > > other more release-critical work, this was not my intention :-(. > > I tend to disagree here (as Agustin). If this was the case the package > would have the 'squeeze-will-remove' tag at least until now. For what > I know amavisd is used in Debian SMTP infrastructure which might be a > strong reason to accept this small fix in Debian 6.0. If there are > other issues (ie. with libmilter) that's another issue which might > indeed cause its removal. As far as I know there are not many installations using amavisd-new with milter so I guess the impact should be fairly minimal - my main objection currently is that I have seen no amavisd-milter installation which runs stable with the current libmilter version in testing and I do not see any interest of the release team in fixing it. > > Thanks > Thanks for your valuable input Harald -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
