Package: sqlite3
Version: 3.7.4-2
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu natty ubuntu-patch
Hi Laszlo,
So shortly after uploading the change from bug #611949 to Ubuntu, I received
a report that the ABI had regressed. This wasn't a bug in the patch I had
applied; rather it was a change in behavior in cdbs 0.4.90 and above, which
no longer honors the DEB_OPT_FLAG variable that you were using in
debian/rules to set build options.
The attached patch sets these options in CFLAGS instead; I've uploaded it to
Ubuntu with the following changelog entry:
* debian/rules: don't use DEB_OPT_FLAG, which seems to have never been
officially supported by cdbs and has now gone away; set CFLAGS directly
instead.
It's probably a good idea if you do the same, sometime before the next cdbs
upload to unstable. Also, perhaps this is a good time to consider switching
from cdbs to dh(1), which would never trick you into using a variable that
isn't supported. ;)
BTW, applying the fix for bug #609946 is probably also a good idea, to avoid
future ABI-changing package misbuilds.
Cheers,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
diff -Nru sqlite3-3.7.4/debian/rules sqlite3-3.7.4/debian/rules
--- sqlite3-3.7.4/debian/rules 2011-01-30 22:12:56.000000000 -0800
+++ sqlite3-3.7.4/debian/rules 2011-02-03 18:55:58.000000000 -0800
@@ -67,7 +67,6 @@
DEB_SHLIBDEPS_LIBRARY_sqlite := libsqlite3-$(so_version)
DEB_SHLIBDEPS_INCLUDE_sqlite := debian/libsqlite3-$(so_version)/usr/lib/
-#DEB_OPT_FLAG := -O2 -fno-strict-aliasing -DSQLITE_ENABLE_COLUMN_METADATA -DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_RTREE=1 -DSQLITE_ENABLE_ICU=1
-DEB_OPT_FLAG := -O2 -fno-strict-aliasing -DSQLITE_SECURE_DELETE -DSQLITE_ENABLE_COLUMN_METADATA -DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_RTREE=1 -DSQLITE_SOUNDEX=1 -DSQLITE_ENABLE_UNLOCK_NOTIFY
+CFLAGS += -O2 -fno-strict-aliasing -DSQLITE_SECURE_DELETE -DSQLITE_ENABLE_COLUMN_METADATA -DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_RTREE=1 -DSQLITE_SOUNDEX=1 -DSQLITE_ENABLE_UNLOCK_NOTIFY
DEB_DH_STRIP_ARGS := --dbg-package=libsqlite3-$(so_version)-dbg
