tags 611855 + fixed-upstream patch thanks On Thu, Feb 17, 2011 at 03:30:34PM +0900, Hiroyuki Yamamoto wrote: > > > It seems that I have found the cause of problem. > > > Please try the attached patch to see it fixes the crash.
> The change has been made since 3.1beta2. Actually messages are added > with sorted but without threading until receiving will be completed. > Before 3.1beta2, messages were not appeared at all until completing > receiving. It has been a month since this fix applied, sylpheed does not crash. So I set tags and attach fix patch from upstream SVN. -- Regards, dai GPG Fingerprint = 0B29 D88E 42E6 B765 B8D8 EA50 7839 619D D439 668E
Index: sylpheed/src/summaryview.c =================================================================== --- sylpheed/src/summaryview.c (revision 2818) +++ sylpheed/src/summaryview.c (revision 2845) @@ -1120,6 +1120,7 @@ summaryview->all_mlist = g_slist_concat(summaryview->all_mlist, qlist); item->cache_dirty = TRUE; + summary_selection_list_free(summaryview); summary_status_show(summaryview); @@ -2204,10 +2205,12 @@ GtkTreeIter iter; GtkTreePath *path = (GtkTreePath *)cur->data; - gtk_tree_model_get_iter(model, &iter, path); - gtk_tree_model_get(model, &iter, S_COL_MSG_INFO, &msginfo, -1); - sel_size += msginfo->size; - n_selected++; + if (gtk_tree_model_get_iter(model, &iter, path)) { + gtk_tree_model_get(model, &iter, + S_COL_MSG_INFO, &msginfo, -1); + sel_size += msginfo->size; + n_selected++; + } } if (FOLDER_TYPE(summaryview->folder_item->folder) == F_NEWS) {
signature.asc
Description: Digital signature