On 31/03/11 13:33, Axel Beckert wrote:
Hi Alex,
Alex Tomlins wrote:
I don't like the inheritance of the dom0 apt settings as they are
correct only if the target VM is of the same type as dom0. IOW, using a
debian dom0's apt setup to build an ubuntu VM is probably wrong as the
mirror/proxy could be different.
Leaving it as a cmdline arg would be preferable IMHO.
An alternative approach would be to be able to specify an apt proxy
server within xen-tools.
That would be helpful in some situations anyway, and it would be a
workaround around the problem described in this bug. But I regard it
only as workaround, not as solution.
I've implemented this here:
https://gitorious.org/~alext/xen-tools/alext-xen-tools/commits/apt_proxy
Thanks!
From a first glance it looks good and I'll probably include your
patches. I'd though change two things:
* Change the option's name from apt_proxy to apt-proxy.
Makes sense. I wasn't sure which way to go as the existing options seem
to use a mixture. I'll change it and push the change up into that branch.
* Instead of prepending the environment variable to some command, I'd
prefer to use $ENV{http_proxy}, etc.
I was mostly being cautious there to make sure it didn't effect anything
else (as the proxy is typically an apt-cacher type proxy, and not a
general http proxy). Having had a closer look, I can't see it effecting
anything else, so I'll push that change up as well
Anyway, thanks for the patches. Will pull them at least for the next
major release.
That would be great,
thanks,
Alex
--
Alex Tomlins
Unboxed
Consulting
E: [email protected]
<mailto:[email protected]>
M: +44 7824 696 890
T: +44 20 3137 2930
F: +44 20 7183 4251
17 Blossom Street
London, E1 6PL
United Kingdom
www.unboxedconsulting.com <http://www.unboxedconsulting.com>
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
