On Sat, Apr 02, 2011 at 09:00:46PM +0100, Robin Cornelius wrote: > On Fri, Apr 1, 2011 at 10:39 PM, Steve Langasek > <[email protected]> wrote:
> > The attached patch fixes src/Makefile.am to use -L$(EXPAT_LIB_LOCATION) > > -lexpat instead. This is best practice with libtool; "foo_LDADD = > > /path/to/libbar.la" should really only be used for dependent libraries > > created as part of the build, not for external libs. As such, this patch > > should let xmlrpc-epi build correctly against both a multiarch and a > > pre-multiarch libexpat. > Thanks for that, i'll take a peek and apply it soon > > Since multiarch is imminent in Debian, I would appreciate it if you could > > apply this to the Debian package and forward it upstream. > I've also got the keys to upstream so i can do both, although i am not > a DD myself only a DM and my previous sponsor has become overloaded > and reduced his sponsoring, so it would be helpful to get a sponsored > upload for this too. I'm happy to sponsor this for you when you're ready for upload. > > BTW, I notice that there are further checks in configure.in that are not > > consistent with autotools best practices and which will also break if > > libexpat-dev ever has to move expat.h to a multiarch include directory. > I'll take a look at this too, thanks > I'll try to get these looked at in a few days, but please keep poking > me if i forget. Ack :) -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ [email protected] [email protected]
signature.asc
Description: Digital signature
