Hi!

On Sat, 2011-04-09 at 01:44:17 +0200, Raphael Hertzog wrote:
> Anyway, I have always found those error messages very hard to grasp
> and badly worded.

Yeah, the "buffer api" in general has not been the pretiest thing.

> I took this opportunity to improve all those that are related to
> buffer_copy().

> Attached is a patch. Reviews welcome (including from translators since I
> quite some strings).

> With my patch, your error message would have been:
> dpkg-deb (subprocess): unexpected end of input while copying ar member 
> 'data.tar' from '/local/downloads/skype-debian_2.2.0.25-1_amd64.deb' to 
> decompressor
> 
> At least you have a chance to guess that your .deb file was truncated and
> is not complete.

It seems the patch didn't get attached, but AFAICS it's this one:

  <http://git.debian.org/?p=users/hertzog/dpkg.git;a=commitdiff;h=662fb936>

While I think the new strings in general are an improvement, if the
api requires to annotate every call site for the translators then IMO
the api itself is not adequate.

So, let me finish and push my changes to the buffer api, and then we
revisit this after that, ok?

thanks,
guillem



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to