Source: qmmp Version: 0.5.0-1 Severity: important Tags: patch User: pkg-utopia-maintain...@lists.alioth.debian.org Usertags: halectomy
Hi, HAL has been deprecated and declared dead upstream so we want to get rid of it eventually in Debian [1]. qmmp has both an hal plugin and an udisks one, shipped in libqmmp-misc; what can be done is disable the hal plugin on Linux architectures, and disable the udisks one on non-Linux ones (as udisks at the moment is highly Linux-specific). The attached patch does the job explained already, adding also ad-hoc suggestions to the libqmmp-misc package. [1] http://wiki.debian.org/HALRemoval Thanks, -- Pino
--- a/debian/rules +++ b/debian/rules @@ -1,6 +1,7 @@ #!/usr/bin/make -f # -*- makefile -*- +DEB_HOST_ARCH_OS ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_OS) DEBDIR=debian/tmp ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS))) @@ -8,13 +9,19 @@ MAKE_AUX_FLAGS = -j$(NUMJOBS) endif +ifeq ($(DEB_HOST_ARCH_OS),linux) + EXTRA_CMAKE_ARGS = -DUSE_HAL:BOOL=FALSE +else + EXTRA_CMAKE_ARGS = -DUSE_UDISKS:BOOL=FALSE +endif + %: dh $@ build: build-stamp build-stamp: dh build --before configure - cmake -DCMAKE_INSTALL_PREFIX=/usr -DUSE_BS2B:BOOL=FALSE + cmake -DCMAKE_INSTALL_PREFIX=/usr -DUSE_BS2B:BOOL=FALSE $(EXTRA_CMAKE_ARGS) dh build --after configure -- $(MAKE_AUX_FLAGS) touch build-stamp --- a/debian/control +++ b/debian/control @@ -68,7 +68,7 @@ Package: libqmmp-misc Architecture: any Depends: ${misc:Depends}, ${shlibs:Depends} -Suggests: qmmp (= ${binary:Version}) +Suggests: qmmp (= ${binary:Version}), udisks [linux-any], hal [!linux-any] Description: qmmp audio player -- plugins and auxiliary libraries Qmmp is feature-rich audio player with support of many formats. It is written in Qt.