On 04/26/2011 12:43 AM, greg schmidt wrote:
Sorry, the patch I proposed doesn't work, in fact it doesn't really
change any thing. I was not familiar with the post decrement used in the
test clause of the for and didn't understand the code. It seems that my
locally compiled version just fails less often. Maybe 1 in 10 tries. The
fault signature changed to
rsync: hlink.c:538: finish_hard_link: Assertion `node != ((void *)0) &&
node->data != ((void *)0)' failed.
rsync: connection unexpectedly closed (25 bytes received so far) [sender]
rsync error: error in rsync protocol data stream (code 12) at io.c(601)
[sender=3.0.7]
It may be prudent to reduce the priority or close this report. I will
spend a bit more time attempting to isolate the problem. While the
difference between the backintime snapshot and the working copy expose
the problem.
Greg
Package: rsync
Version: 3.0.7-2
Severity: important
Tags: patch
backintime started failing, isolated to rsync, fault signature would change
depending upon the command line options. The tail of rsync output had several
incorrect hardlink operations and a error from finish_hard_link()
BACKINTIME:>f+++++++++ home/greg/canons3/new/MVI_4710.AVI
BACKINTIME: hf home/greg/canons3/party/20110114_122108.JPG =>
home/greg/canons3/party/20110114_121939.JPG
BACKINTIME: hf home/greg/canons3/party/20110114_135612.JPG =>
home/greg/canons3/party/20110114_121939.JPG
BACKINTIME: hf home/greg/canons3/party/20110114_135733.JPG =>
home/greg/canons3/party/20110114_121939.JPG
BACKINTIME: hf home/greg/canons3/party/20110114_132023.JPG =>
home/greg/canons3/party/20110114_121939.JPG
BACKINTIME: hf home/greg/canons3/party/20110114_131542.JPG =>
home/greg/canons3/party/20110114_121939.JPG
BACKINTIME: hf home/greg/canons3/party/20110114_131330.JPG =>
home/greg/canons3/party/20110114_121939.JPG
BACKINTIME: hf home/greg/canons3/party/20110114_123447.AVI =>
home/greg/canons3/party/20110114_121939.JPG
File-list index 0 not in 7644 - 7932 (finish_hard_link) [generator]
rsync error: protocol incompatibility (code 2) at rsync.c(646)
[generator=3.0.7]
rsync: connection unexpectedly closed (1632 bytes received so far) [sender]
rsync error: error in rsync protocol data stream (code 12) at io.c(601)
[sender=3.0.7]
I found a problem in the hashtable grow. The loop that inserts the nonzero
nodes from the old array to the new one copies from size to 1, but should copy
from size-1 to 0.
i changed hashtable.c as follows
greg@desk1:~/rsync-3.0.7$ diff hashtable.c o.hashtable.c
73c73
< for (i = (size/2)-1;i>=0;i--){
---
for (i = size / 2; i--> 0; ) {
And It appears to work for my case
-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.38-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages rsync depends on:
ii base-files 6.3 Debian base system miscellaneous f
ii libacl1 2.2.49-4 Access control list shared library
ii libc6 2.11.2-11 Embedded GNU C Library: Shared lib
ii libpopt0 1.16-1 lib for parsing cmdline parameters
ii lsb-base 3.2-27 Linux Standard Base 3.2 init scrip
rsync recommends no packages.
Versions of packages rsync suggests:
ii openssh-client 1:5.5p1-6 secure shell (SSH) client, for sec
pn openssh-server<none> (no description available)
-- no debconf information
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
