Hello again,

attached is an updated patch to fix this FTBFS. The original patch was
flawed because it added the libraries to LDFLAGS, which is wrong. Now
the libraries are in LDADD which is appended after the objects/sources.
This also fixes a bug when building with ld --as-needed, see
https://bugs.launchpad.net/ubuntu/+source/audtty/+bug/765955

Thanks for considering the patch.

Cheers,

Andreas
Description: Fix FTBFS due to indirect linking
Author: Andreas Moog <[email protected]>
Bug-Ubuntu: https://bugs.launchpad.net/749143
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=618068

Index: audtty/Makefile.in
===================================================================
--- audtty.orig/Makefile.in	2011-06-23 09:35:45.224190999 +0000
+++ audtty/Makefile.in	2011-06-23 09:36:31.844191736 +0000
@@ -8,6 +8,7 @@
 
 
 AUDACIOUS_CFLAGS=@AUDACIOUS_CFLAGS@ -I/usr/include/dbus-1.0
+LDADD=-ldbus-glib-1 -lncursesw -laudclient
 
 SOURCES=main.c curses_printf.c playlist.c playlist_jump.c playlist_addurl.c settings.c connect.c browse.c playlist_create.c
 BINS=$(SOURCES:.c=.o)
@@ -17,7 +18,7 @@
 all: audtty
 
 audtty: ${BINS}
-	cc -g -O2 -g2 -Wall -Werror -lncursesw -laudclient ${LDFLAGS} -o audtty $(BINS)
+	cc -g -O2 -g2 -Wall -Werror ${LDFLAGS} -o audtty $(BINS) $(LDADD)
 
 .c.o:
 	cc -g -Wall ${AUDACIOUS_CFLAGS} ${CFLAGS} -o $@ -c $<

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to