(+cc: a related bug log. I hope that's ok) Hi Cedric, Cedric Vivier wrote:
> I'd like to check with you the status of the patch you wrote some > months/years ago to add --patience to git add. > Did you submit this patch upstream? Are you intending to do so? > > If not, I'd be willing to try moving this upstream myself (with > appropriate credit of course) as this is indeed a very handy feature I assume you mean the patches at [1]. If so, please do feel free to push them forward. The pieces I felt were missing at the time if I remember correctly were: - documentation - a simple testcase under t/ to show how it works - it seemed odd that internally this doesn't use a diff_options array or struct or something. For example, someone might want to do "git add -p --ignore-space-change" in the future. Though that would require using "git apply --ignore-space-change" behind the scenes while at it, so maybe that thought wasn't quite right. Meanwhile, you are quite right that the patches are useful already, so sending the patch series for people to use or build on sounds like an excellent thing to do. Thanks for the offer. :) Jonathan [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?mbox=yes;bug=522361 -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
