On Thu, Jul 14, 2011 at 04:40:12PM +0200, Bastien ROUCARIES wrote: > I needed to check the source how you export the tar.gz using pristine-tar and > what parameters (particularly delta) you pass to pristine-tar. > > Moreover could you emphasize the need to select the good hook in order to use > the good compression method. If I had pristine-tar a tar.bz2 i need to set > the gitpkg.orig-compressor config. I forget to add it and it fail
Ah, so this isn't actually a "documentation bug" then ... It's really a real bug, or rather really two real bugs if you consider that both gitpkg and p-t are affected by the same issue ... You are correct in that at present the gitpkg.orig-compressor must be set to match the type of file you are expecting p-t to export -- but that said, requiring you to set that manually for this case is quite wrong. Doing so would then mean that for repos which started with tar.gz p-t imports, and later switched to some other compression format, you would have to manually reconfigure gitpkg.orig-compressor again before exporting older versions, and also mean that other users would not be able to export your packages without also first configuring that option correctly for the version that they wish to export. It's not entirely surprising that both gitpkg and p-t have been caught out by this, since they both existed before multiple compression formats were supported in the archive - but we do need to do something better than just formalise the current bad situation in the documentation. For gitpkg alone, this shouldn't be hard to fix, the gitpkg.orig-compressor option is really only intended for _creating_ a tarball that was exported from the git repo as a raw upstream source. So gitpkg should just ignore it in the case where an orig is already present and not being exported. What to do about p-t is a little less clear though, since unless I am mistaken it requires us to specify the full name of the tarball (including its compression type) before it can export it. But what we really want is the opposite of that - we don't really care what the compression type is, we just want it to export the tarball it recorded as corresponding to the version that we want to export. We might be able to hack around that with some grovelling around in the p-t branch before requesting an export, but it's probably better if we talk to the p-t maintainers first and implement a suitable mechanism for that in p-t itself. Then the gitpkg hook can just make use of that. Will look into this further. Cheers, Ron -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
