tag 572452 +pending
thanks
Hi,
On Thu, Mar 04, 2010 at 12:17:27PM +0100, Matthijs Kooijman wrote:
> Package: git-buildpackage
> Version: 0.4.65~3.gbp3ceaa3
> Severity: minor
>
> Hi,
>
> I thought to try --fast-import, since I had some problems with normal
> import adding files that were ignored by upstreams .gitignore (and thus
> didn't show up in git status when I cleaned the tree before importing).
>
> Anyway, after importing using --fast-import, I noticed that it had
> created the upstream import commit using just my username as author
> name, instead of my full name (from /etc/passwd). Looking at the code,
> it seems that GitRepository.get_author_info() tries to emulate git's
> behaviour, but apparently neglects to do a /etc/passwd / NSS lookup when
> it uses the current username as a name.
>
> It seems this is a matter of doing
> name = pwd.getpwnam(name)[4].split(',')[0]
> after getting the value of $USER, with some error handling of course.
>
> However, isn't there some way to let git do all this stuff instead of
> recreating git's name guessing algorithms in gbp? That would of course
> be a lot better and more predictable...
I've dropped fast-import from current git since it didn't make lots of
progress during the last year. You're issue with upstream's .gitignore
can be fixed by using --git-filter=.gitignore I guess.
Cheers,
-- Guido
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
