Package: pacpl Version: 4.0.5-6 Severity: normal Tags: patch Trying to encode to mp3 no longer works. When specifying --encoder lame --to mp3, the patent warning message is displayed even though I have lame installed.
The attached patch, if deemed acceptable, would replace the current debian/patches/35_pacpl_patent-warning-for-mp3-using-lame.patch. With this patch applied pacpl works with lame again. -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (990, 'testing'), (500, 'stable'), (50, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.39-2-amd64 (SMP w/2 CPU cores) Locale: LANG=fi_FI.UTF-8, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages pacpl depends on: ii libaudio-flac-header-perl 2.4-1+b1 Perl interface to FLAC file header ii libaudio-musepack-perl 1.0.1-1 object-oriented interface to Musep ii libaudio-wma-perl 1.3-1 perl extension for reading WMA/ASF ii libcddb-get-perl 2.27-1 Perl interface to read the CDDB en ii libmp3-tag-perl 1.12-1 Module for reading tags of MP3 aud ii libmp4-info-perl 1.13-1 Fetch info from MPEG-4 files ii libogg-vorbis-header-perl 0.03-3+b2 perl interface to Ogg Vorbis infor ii perl 5.12.4-1 Larry Wall's Practical Extraction Versions of packages pacpl recommends: ii cdparanoia 3.10.2+debian-10 audio extraction tool for sampling ii faad 2.7-6 freeware Advanced Audio Decoder pl ii ffmpeg 5:0.8-0.1 audio/video encoder, streaming ser ii flac 1.2.1-4 Free Lossless Audio Codec - comman ii flake 0.11-2 Alternative encoder for the Free L ii mplayer-nogui 3:1.0~rc4+svn20110505-0.2 The Ultimate Movie Player For Linu ii mppenc 1.16-1 Musepack lossy audio codec encoder ii normalize-audi 0.7.7-7 adjusts the volume of WAV, MP3 and ii sndfile-progra 1.0.25-2 Sample programs that use libsndfil ii sox 14.3.2-1 Swiss army knife of sound processi ii speex 1.2~rc1-1 The Speex codec command line tools ii vorbis-tools 1.4.0-1 several Ogg Vorbis tools ii wavpack 4.60.1-1 an audio codec (lossy and lossless Versions of packages pacpl suggests: ii dolphin 4:4.6.5-1 file manager ii kommander 4:4.6.5-1 visual dialog builder and executor ii konqueror 4:4.6.5-1 advanced file manager, web browser ii twolame 0.3.13-1 MPEG Audio Layer 2 encoder (comman -- no debconf information
Description: Add a patent warning about mp3 patents. IF the user request mpeg layer 3 encoding with "--to mp3" and/or with "--encoder lame" AND lame is not installed on the system THEN pacpl print a warning with links about mp3 patents and links to get the non-free lame source code / package and exit(1). . codecs.conf: Changed default MP3 decoder from lame to ffmpeg. Author: Maxime Chatelle <[email protected]> Forwarded: not-needed Last-Update: 2011-06-20 Bug-Debian: http://bugs.debian.org/608601 Index: pacpl/codecs.conf =================================================================== --- pacpl.orig/codecs.conf 2011-06-24 02:25:57.107052961 +0200 +++ pacpl/codecs.conf 2011-06-24 23:03:32.037978444 +0200 @@ -27,7 +27,7 @@ # encoders: lame, bladeenc, gogo, toolame, ffmpeg, sox # decoders: lame, ffmpeg, mplayer, sox # -MP3 = lame,lame +MP3 = lame,ffmpeg # encoders: oggenc, ffmpeg, sox # decoders: oggdec, ffmpeg, mplayer, sox Index: pacpl/pacpl =================================================================== --- pacpl.orig/pacpl 2011-06-24 23:03:32.001978444 +0200 +++ pacpl/pacpl 2011-06-24 23:04:01.397978434 +0200 @@ -1780,6 +1780,32 @@ kill 9, $$; }; + + # Debian mod: issue a warning about patent and finish program if wanted + # encoder is lame and it is not found in the path. + if ($encoder eq "lame" and not `which lame`) + { + print ' +You requested MPEG layer 3 encoding using the "lame" encoder but due to +patent issues lame cannot be included in Debian. + +If you still want to use this patented file format, consider installing lame +from http://lame.sourceforge.net/ (sources) +or +http://debian-multimedia.org/ (_unofficial_ debian packages). + +Additional information about MPEG Layer 3 patents can be found here : +http://www.mp3-tech.org/patents.html +and +https://secure.wikimedia.org/wikipedia/en/wiki/MP3#Licensing_and_patent_issues + +Open source MP3 decoders may be royalty free but this can change if the +patent holder changes his mind. + +'; + exit (1); + } + # check to see if encoder/decoder exists. if not, see if we have one # that supports the desired input/output formats. check_encoder();
signature.asc
Description: Digital signature
