Package: pidgin-libnotify
Version: 0.14-5+b1
Severity: minor
Tags: patch
--- Please enter the report below this line. ---
When building the plugin, gcc issues following warning several times:
format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type
‘struct NotifyNotification *’ [-Wformat]
Attached patch fixes these warnings. As pidgin-libnotify upstream seems
inactive for some time already,
I am posting it at least here.
--- System information. ---
Architecture: amd64
Kernel: Linux 3.0.0-1-amd64
Debian Release: wheezy/sid
500 unstable ftp.cz.debian.org
500 unstable emdebian.org
500 testing www.debian-multimedia.org
500 testing security.debian.org
500 testing ftp.cz.debian.org
1 experimental ftp.debian.org
--- Package information. ---
Depends (Version) | Installed
==================================-+-============
libatk1.0-0 (>= 1.12.4) | 2.0.1-2
libc6 (>= 2.2.5) | 2.13-16
libcairo2 (>= 1.2.4) | 1.10.2-6.1
libfontconfig1 (>= 2.8.0) | 2.8.0-3
libfreetype6 (>= 2.2.1) | 2.4.6-1
libgdk-pixbuf2.0-0 (>= 2.22.0) | 2.23.5-3
libglib2.0-0 (>= 2.16.0) | 2.28.6-1
libgtk2.0-0 (>= 2.8.0) | 2.24.4-3
libnotify4 (>= 0.7.0) | 0.7.3-2
libpango1.0-0 (>= 1.14.0) | 1.28.4-1
pidgin (<< 3.0) | 2.9.0-3
pidgin (>= 2.9) | 2.9.0-3
Package's Recommends field is empty.
Package's Suggests field is empty.
From: Jakub Adam <[email protected]>
Date: Sat, 20 Aug 2011 21:49:14 +0200
Subject: fix-printf-warnings.diff
Fix compiler warnings - replace 0x%x -> %p in printf format strings
Signed-off-by: Jakub Adam <[email protected]>
---
src/pidgin-libnotify.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/pidgin-libnotify.c b/src/pidgin-libnotify.c
index 5290584..ab166d1 100644
--- a/src/pidgin-libnotify.c
+++ b/src/pidgin-libnotify.c
@@ -181,7 +181,7 @@ action_cb (NotifyNotification *notification,
PurpleConversation *conv = NULL;
purple_debug_info (PLUGIN_ID, "action_cb(), "
- "notification: 0x%x, action: '%s'", notification, action);
+ "notification: %p, action: '%s'", notification, action);
buddy = (PurpleBuddy *)g_object_get_data (G_OBJECT(notification), "buddy");
@@ -207,7 +207,7 @@ closed_cb (NotifyNotification *notification)
{
PurpleContact *contact;
- purple_debug_info (PLUGIN_ID, "closed_cb(), notification: 0x%x\n", notification);
+ purple_debug_info (PLUGIN_ID, "closed_cb(), notification: %p\n", notification);
contact = (PurpleContact *)g_object_get_data (G_OBJECT(notification), "contact");
if (contact)
@@ -449,13 +449,13 @@ notify_new_message_cb (PurpleAccount *account,
#ifndef DEBUG /* in debug mode, always show notifications */
if (conv && purple_conversation_has_focus (conv)) {
- purple_debug_info (PLUGIN_ID, "Conversation has focus 0x%x\n", conv);
+ purple_debug_info (PLUGIN_ID, "Conversation has focus %p\n", conv);
return;
}
#endif
if (conv && purple_prefs_get_bool ("/plugins/gtk/libnotify/newconvonly")) {
- purple_debug_info (PLUGIN_ID, "Conversation is not new 0x%x\n", conv);
+ purple_debug_info (PLUGIN_ID, "Conversation is not new %p\n", conv);
return;
}
--
