Package: squidguard
Version: 1.4-2
Severity: important
Tags: upstream

As raised on the squidguard mailing list at
http://www.shalla.de/mailman/private/squidguard/2011-August/002135.html
(not all messages have appeared in the archive at time of writing).

When using a rewrite rule in squidGuard, if the URL contains a %20 (and
potentially other encodings), anything after the final % character is not
included in the URL.

As an example:

http://www.example.com/?query=example%20query%20string

Would be rewritten as

http://www.example.com/?query=example%20query%

(with any regular expression changes which would normally be applied by
your rewrite rule)

This has a major effect on usability of the rewrite rule for use cases such
as enforcing google safe search. Most of these methods use a rewrite rule
such as:

    s@(setprefs\?)(.*)safeui=[^\&]*@setprefs\?safe=on\&\2safeui=on@
    s@(setprefs\?)@setprefs\?safe=on\&safeui=on\&@
    s@(\?)@\?safe=strict\&@

Since Google use a URL redirector when links are clicked on, the redirector
URLs are also modified for safe search, and include the original search
term. If the search term contains a space, then everything after that %20
is removed, including the URL validation. Without this, when a user clicks
on a link, they are told that they are being redirected and asked to click
on to confirm before continuing.

I believe that a use case is missing from sgDiv.c.in sgParseRedirect().

I have submitted a patch to the squidGuard mailing list for feedback.

-- System Information:
Debian Release: 6.0.2
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-vserver-686-bigmem (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to