usertags 495046 + typo error-prone
quit
On 14 August 2008 16:02, ygrek <[email protected]> wrote:
> In the description shown . and , have intermixed description. Obviously it
> should be , for prev and
> . for next solution
...
>> ,: move to the next solution
>> .: move to the previous solution
Fixing the help text is trivial. Looking at the code it's easy to see
how the mistake happened
static void resolver_help(ostream &out,
const shared_ptr<terminal_metrics> &term_metrics)
{
cw::fragment *f=indentbox(2, 2,
cw::fragf(_("y: %F"
"n: %F"
"q: %F"
",: %F"
".: %F"
...
flowindentbox(0, 3,
cw::fragf(_("move to the next solution"))),
flowindentbox(0, 3,
cw::fragf(_("move to the previous solution"))),
Very error prone ;) as the descriptive text is far away from the cmd
text. It is also not very translator friendly for the same reason
(and "y: %Fn: %F:q: %f" appears as one big string).
This code should probably be reworked, but I do not know much about
the cwidget code as of yet. Though I think something like this might
work
cw::fragf(_("y: %F"),
flowindentbox(0, 3, cw::fragf(_("accept the proposed changes"))));
cw::fragf(_("n: %F"),
flowindentbox(0, 3, cw::fragf(_("reject the proposed changes"))));
...
where most of that code could be factored out to a loop over a struct
{_("y: %F"), 0, 3, _("accept the proposed changes")}
...
Would work for now since each line has the same form, but may not
be flexible enough for the future.
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
