I contacted Sébastien Villemot about the package on mentors, but he told me 
that he is not interested in taking over the package at the moment. So I just 
forward my mail to this bug for the next/(current?) maintainer.

Kind regards,
        Sven
--- Begin Message ---
Hi,

I noticed that you have an outdated picard package on mentors. You could 
import 1.15.1 and fix the bug 638244 (a release critical bug).

I also looked through the package a little bit and was irritated that you 
still use pre dh debhelper and why you depend on libfftw3-3. Shouldn't be 
libofa be the only thing which links against it and therefore mark the 
Requires in their libofa.pc as Requires.private? Maybe you could investigate 
that problem further.

I've attached a test patch for dh support... but I have to say that I've never 
packaged a python program and thus it may be completely wrong.

And you should look at the new copyright format (currently called DEP-5). 
Maybe it is also a good idea to share the /usr/share stuff between all 
architectures (at least 4.2 MiB aka 97% are architecture independent files) 
and depend on an extra binary package (or something like that).

Kind regards,
        Sven
>From 7d54e6701b59f0548a7dd431d56b9e6789a93ee2 Mon Sep 17 00:00:00 2001
From: Sven Eckelmann <s...@narfation.org>
Date: Mon, 12 Sep 2011 10:57:44 +0200
Subject: [PATCH] Test dh rules file


Signed-off-by: Sven Eckelmann <s...@narfation.org>
---
 debian/compat  |    2 +-
 debian/control |    3 +-
 debian/rules   |   70 ++++++++++++++++++++-----------------------------------
 3 files changed, 29 insertions(+), 46 deletions(-)

diff --git a/debian/compat b/debian/compat
index 7ed6ff8..45a4fb7 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@
-5
+8
diff --git a/debian/control b/debian/control
index fec7eab..7bc29ac 100644
--- a/debian/control
+++ b/debian/control
@@ -3,10 +3,11 @@ Section: sound
 Priority: optional
 Maintainer: Adam Cécile (Le_Vert) <gand...@le-vert.net>
 Uploaders: Sébastien Villemot <sebastien.ville...@ens.fr>
-Build-Depends: debhelper (>= 5.0.51~),
+Build-Depends: debhelper (>= 8.0.0),
  python-all-dev (>= 2.6),
  python-support (>= 0.4),
  gettext,
+ hardening-includes,
  libofa0-dev,
  libavcodec-dev,
  libavformat-dev,
diff --git a/debian/rules b/debian/rules
index aeebf78..ac77271 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,34 +1,35 @@
 #!/usr/bin/make -f
+# -*- makefile -*-
 
-PYVERS  = $(shell pyversions -rv)
 DESTDIR = $(CURDIR)/debian/picard
 
-CFLAGS = -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)
+export CFLAGS=$(shell dpkg-buildflags --get CFLAGS)
+export CPPFLAGS=$(shell dpkg-buildflags --get CPPFLAGS)
+export CXXFLAGS=$(shell dpkg-buildflags --get CXXFLAGS)
+export LDFLAGS=$(shell dpkg-buildflags --get LDFLAGS)
 
-build: $(PYVERS:%=build-stamp%)
+DEB_BUILD_HARDENING_PIE:=0
+include /usr/share/hardening-includes/hardening.make
+CFLAGS += $(HARDENING_CFLAGS)
+CXXFLAGS += $(HARDENING_CFLAGS)
+LDFLAGS += $(HARDENING_LDFLAGS)
 
-build-stamp%:
-	dh_testdir
+LDFLAGS += -Wl,--as-needed
+
+binary binary-arch binary-indep build build-arch build-indep clean install install-arch install-indep:
+	dh $@ --parallel
+
+override_dh_auto_build:
 	echo "# let it installed by recent python-support" > picard/plugins/__init__.py
-	CFLAGS="$(CFLAGS)" python$* setup.py config
-	CFLAGS="$(CFLAGS)" python$* setup.py build_ext
-	python$* setup.py install --root=$(DESTDIR) --prefix=/usr \
-	  --no-compile --disable-autoupdate
+	dh_auto_build -- config build --disable-autoupdate
+
+override_dh_auto_clean:
+	dh_auto_clean
 	rm -rf build/ build.cfg scripts/picard
-	touch $@
-
-clean:
-	dh_testdir
-	dh_testroot
 	> picard/plugins/__init__.py
-	rm -rf build/ build.cfg scripts/picard build-stamp*
-	find $(CURDIR) \( -name '*.mo' -o -name '*.pyc' \) -delete
-	dh_clean
 
-install: build
-	dh_testdir
-	dh_testroot
-	dh_installdirs
+override_dh_auto_install:
+	dh_auto_install
 	# Let's create some icons
 	mkdir -p $(DESTDIR)/usr/share/pixmaps
 	for size in 16 22 24 32 36 48 64 72 96 128 192 256; do \
@@ -37,28 +38,9 @@ install: build
 		convert $(CURDIR)/resources/img-src/Picard-256.svg -resize $${size} $(DESTDIR)/usr/share/icons/hicolor/$${size}x$${size}/apps/picard.png || exit 1; \
 	done
 	install -D -m0644 $(CURDIR)/resources/img-src/Picard-256.svg $(DESTDIR)/usr/share/icons/hicolor/scalable/apps/picard.svg
-	# And fix the shebang
-	sed -i 's,^#!/usr/bin/python.*,#!/usr/bin/python,' $(DESTDIR)/usr/bin/picard
 
-binary-indep: build install
-binary-arch: build install
-	dh_testdir
-	dh_testroot
-	dh_installchangelogs -s NEWS.txt
-	dh_installdocs -s
-	dh_installmenu -s
-	dh_icons -s
-	dh_pysupport -s
-	dh_installman -s
-	dh_link -s
-	dh_strip -s
-	dh_compress -s
-	dh_fixperms -s
-	dh_installdeb -s
-	dh_shlibdeps -s
-	dh_gencontrol -s
-	dh_md5sums -s
-	dh_builddeb -s
+override_dh_installchangelogs:
+	dh_installchangelogs NEWS.txt
 
-binary: binary-indep binary-arch
-.PHONY: build clean binary-indep binary-arch binary install
+.PHONY: binary binary-arch binary-indep build build-arch build-indep clean install install-arch install-indep \
+	override_dh_auto_build override_dh_auto_clean override_dh_auto_install override_dh_installchangelogs
-- 
1.7.5.4

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to