Hi,

On 09/29/2011 07:49 AM, Nobuhiro Iwamatsu wrote:
>> I've just tried to build the guppy version from SVN and run the test suite 
>> with
>> Python 2.7 on an amd64 machine. The test suite already fails test1 in
>> guppy/sets/test.py. I've also tried on a 32 bit machine and and their it 
>> didn't
>> fail.
>>
>> The reason is simple: _PyLong_Frexp takes a Py_ssize_t* as second argument 
>> but a
>> int* is passed. Therefor _PyLong_Frexp messes with other variables on the 
>> stack
>> since Py_ssize_t is larger than int on amd64.
>>
>> Attached is a patch to fix this issues.
> 
> I checked this package with your patch on latest unstable.
> This problem does not seem to be settled with your patch.
> I attach build log.

As noted in my first mail, my patch was against the latest SVN revision. And
there these issues were already fixed (see revision 87 from [1] and onwards).
And since Yaroslav explicitly talked about including these changes I didn't
include them in my patch.

Regards,

[1] 
http://guppy-pe.svn.sourceforge.net/viewvc/guppy-pe?view=revision&revision=87

-- 
Sebastian Ramacher

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to