Source: ggobi
Version: 2.1.10-3
Severity: normal
User: [email protected]
Usertags: hardening-format-security hardening

the package ggobi fails to compile with the new hardened compiler flags
dpkg-buildflag outputs [0].
The problematic flag is: -Werror=format-security
See the ubuntu buildlog:
https://launchpadlibrarian.net/83134069/buildlog_ubuntu-precise-i386.ggobi_2.1.10-3_FAILEDTOBUILD.txt.gz
Snippet:
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -pthread
-I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include
-I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/pango-1.0 -I/usr/include/pixman-1
-I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/cairo
-I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -D_FORTIFY_SOURCE=2
-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat
-Wformat-security -Werror=format-security -MT ggobi.lo -MD -MP -MF
.deps/ggobi.Tpo -c ggobi.c  -fPIC -DPIC -o .libs/ggobi.o
ggobi.c: In function 'ValidateGGobiRef':
ggobi.c:701:5: error: format not a string literal and no format
arguments [-Werror=format-security]
ggobi.c:704:5: error: format not a string literal and no format
arguments [-Werror=format-security]
ggobi.c: In function 'ValidateDatadRef':
ggobi.c:721:5: error: format not a string literal and no format
arguments [-Werror=format-security]
ggobi.c:723:5: error: format not a string literal and no format
arguments [-Werror=format-security]
ggobi.c: In function 'ValidateDisplayRef':
ggobi.c:742:5: error: format not a string literal and no format
arguments [-Werror=format-security]
ggobi.c:744:5: error: format not a string literal and no format
arguments [-Werror=format-security]
cc1: some warnings being treated as errors

The buildflags are not exported in debian, but can be enabled e.g. by
adding this to debian/rules:

 DPKG_EXPORT_BUILDFLAGS = 1
 include /usr/share/dpkg/buildflags.mk

Please fix the issues and maybe also enable the hardened build in debian.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html



Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to