Source: leafpad
Version: 0.8.18.1-1
Severity: normal
User: [email protected]
Usertags: hardening-format-security hardening

the package leafpad fails to compile with the new hardened compiler
flags dpkg-buildflag outputs [0].
The problematic flag is: -Werror=format-security
See the ubuntu buildlog:
https://launchpadlibrarian.net/83144457/buildlog_ubuntu-precise-i386.leafpad_0.8.18.1-1_FAILEDTOBUILD.txt.gz
Snippet:
gcc -DHAVE_CONFIG_H -I. -I.. -DICONDIR=\"/usr/share/pixmaps\"
-D_FORTIFY_SOURCE=2 -pthread -I/usr/include/gtk-2.0
-I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0
-I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12
-I/usr/include/cairo -I/usr/include/gio-unix-2.0/
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include    -g -O2
-fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security
-Werror=format-security -Wall -c -o leafpad-dialog.o `test -f 'dialog.c'
|| echo './'`dialog.c
dialog.c: In function 'run_dialog_message':
dialog.c:39:3: error: format not a string literal and no format
arguments [-Werror=format-security]
dialog.c: In function 'create_dialog_message_question':
dialog.c:64:3: error: format not a string literal and no format
arguments [-Werror=format-security]
cc1: some warnings being treated as errors


The buildflags are not exported in debian, but can be enabled e.g. by
adding this to debian/rules:

 DPKG_EXPORT_BUILDFLAGS = 1
 include /usr/share/dpkg/buildflags.mk

Please fix the issues and maybe also enable the hardened build in debian.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html



Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to