Package: gbirthday
Version: 0.6.5-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch precise

gbirthday's upstream Makefile installs to
/usr/lib/python2.6/site-packages/.  If gbirthday is rebuilt from source
using a python package that has dropped Python 2.6 as a supported
version, this means that /usr/share/python-support/private/movemodules
no longer moves it to /usr/share/pyshared, which means that it ends up
not being installed to anywhere in the default interpreter's module
path, and is entirely broken as a result.  On Ubuntu this also causes a
build failure (which seems reasonable given that the resulting package
is going to be unusable):

  
https://launchpadlibrarian.net/83133829/buildlog_ubuntu-precise-i386.gbirthday_0.6.5-1_FAILEDTOBUILD.txt.gz

Furthermore, gbirthday uses python-support, which is now deprecated
(http://lists.debian.org/debian-python/2011/06/msg00136.html).

How about the following patch?  This makes gbirthday a bit more
future-proof, fixes the Ubuntu build failure, and updates to dh_python2
in the process.

  * Always install to /usr/share/pyshared, even if 2.6 is not a supported
    version.
  * Convert to dh_python2.

diff -Nru gbirthday-0.6.5/debian/control gbirthday-0.6.5/debian/control
--- gbirthday-0.6.5/debian/control      2011-09-27 06:42:09.000000000 +0100
+++ gbirthday-0.6.5/debian/control      2011-10-27 13:07:07.000000000 +0100
@@ -3,8 +3,8 @@
 Priority: extra
 Maintainer: Rolf Leggewie <[email protected]>
 DM-Upload-Allowed: yes
-Build-Depends: debhelper (>= 7), python-nose, python-support, python-coverage, 
python-gtk2, intltool
-XS-Python-Version: >= 2.6
+Build-Depends: debhelper (>= 7.0.50~), python (>= 2.6.6-3~), python-nose, 
python-coverage, python-gtk2, intltool
+X-Python-Version: >= 2.6
 Standards-Version: 3.9.2
 Homepage: http://gbirthday.sf.net/
 Vcs-Browser: http://git.debian.org/?p=collab-maint/gbirthday.git
@@ -16,7 +17,6 @@
 Depends: ${shlibs:Depends}, ${misc:Depends}, evolution-data-server, python,
  python-gtk2 (>= 2.10), ${python:Depends}
 Recommends: python-evolution
-XB-Python-Version: ${python:Versions}
 Description: birthday reminder applet
  GBirthday is an applet to help you remember your friends' and contacts'
  birthdays.  It uses the notifcation area for alerts.  Data can be stored
diff -Nru gbirthday-0.6.5/debian/rules gbirthday-0.6.5/debian/rules
--- gbirthday-0.6.5/debian/rules        2011-09-26 02:35:31.000000000 +0100
+++ gbirthday-0.6.5/debian/rules        2011-10-27 13:05:20.000000000 +0100
@@ -1,3 +1,6 @@
 #!/usr/bin/make -f
 %:
-       dh $@
+       dh $@ --with python2
+
+override_dh_auto_install:
+       dh_auto_install -- sitelib=/usr/share/pyshared

Thanks,

-- 
Colin Watson                                       [[email protected]]



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to