Package: beast
Version: 0.7.4-3
Severity: normal
Tags: upstream patch
User: [email protected]
Usertags: hardening-format-security

beast fails to build with -Werror=format-security compiler option.
Build log in Ubuntu:
https://launchpad.net/ubuntu/+source/beast/0.7.4-3/+build/2861170/+files/buildlog_ubuntu-precise-i386.beast_0.7.4-3_FAILEDTOBUILD.txt.gz

See also:
http://wiki.debian.org/Hardening
http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html

Patch from Ubuntu attached.
https://launchpad.net/ubuntu/+source/beast/0.7.4-3ubuntu1

-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric-updates
  APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500, 
'oneiric-proposed'), (500, 'oneiric'), (100, 'oneiric-backports')
Architecture: i386 (i686)

Kernel: Linux 3.0.0-13-generic (SMP w/2 CPU cores)
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Description: fix warnings generated with -Wformat-security
Author: Ilya Barygin <[email protected]>

--- beast-0.7.4.orig/sfi/sfidl-parser.cc
+++ beast-0.7.4/sfi/sfidl-parser.cc
@@ -238,7 +238,7 @@
   if (isSequence (type))      return SEQUENCE;
   if (isRecord (type))	      return RECORD;
   if (isClass (type))	      return OBJECT;
-  g_error (("invalid type: " + type).c_str());
+  g_error ("%s", ("invalid type: " + type).c_str());
   return VOID;
 }
 
--- beast-0.7.4.orig/bse/bsemain.cc
+++ beast-0.7.4/bse/bsemain.cc
@@ -267,9 +267,9 @@
   /* dump device list */
   if (bse_main_args->dump_driver_list)
     {
-      g_printerr (_("\nAvailable PCM drivers:\n"));
+      g_printerr ("%s", _("\nAvailable PCM drivers:\n"));
       bse_device_dump_list (BSE_TYPE_PCM_DEVICE, "  ", TRUE, NULL, NULL);
-      g_printerr (_("\nAvailable MIDI drivers:\n"));
+      g_printerr ("%s", _("\nAvailable MIDI drivers:\n"));
       bse_device_dump_list (BSE_TYPE_MIDI_DEVICE, "  ", TRUE, NULL, NULL);
     }
 }

Reply via email to