Package: iptux
Version: 0.5.2-1
Severity: normal
Tags: upstream patch
User: [email protected]
Usertags: ld-as-needed

iptux fails to build when --as-needed linker option is enabled,
because of incorrect order of parameters passed to ld. Here's a log of
failed build in Ubuntu:
https://launchpadlibrarian.net/83142411/buildlog_ubuntu-precise-i386.iptux_0.5.2-1_FAILEDTOBUILD.txt.gz

See also
http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

The attached patch was used in Ubuntu to fix the problem.
https://launchpad.net/ubuntu/+source/iptux/0.5.2-1ubuntu1

-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric-updates
  APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500, 
'oneiric-proposed'), (500, 'oneiric'), (100, 'oneiric-backports')
Architecture: i386 (i686)

Kernel: Linux 3.0.0-13-generic (SMP w/2 CPU cores)
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Description: fix FTBFS with --as-needed linker option
 Place libaries in LIBS variable rather than LDFLAGS to ensure correct order
 of parameters passed to linker.
Author: Ilya Barygin <[email protected]>

--- iptux-0.5.2.orig/src/Makefile.am
+++ iptux-0.5.2/src/Makefile.am
@@ -13,7 +13,7 @@
 INCLUDES= $(all_includes) @PACKAGE_CFLAGS@
 
 # the library search path.
-iptux_LDFLAGS = $(all_libraries) @PACKAGE_LIBS@
+LIBS = $(all_libraries) @PACKAGE_LIBS@
 
 noinst_HEADERS = AnalogFS.h Command.h CoreThread.h DataSettings.h DetectPal.h DialogBase.h \
 	DialogGroup.h DialogPeer.h HelpDialog.h LogSystem.h MainWindow.h ProgramData.h \
--- iptux-0.5.2.orig/src/Makefile.in
+++ iptux-0.5.2/src/Makefile.in
@@ -256,7 +256,7 @@
 INCLUDES = $(all_includes) @PACKAGE_CFLAGS@
 
 # the library search path.
-iptux_LDFLAGS = $(all_libraries) @PACKAGE_LIBS@
+LIBS = $(all_libraries) @PACKAGE_LIBS@
 noinst_HEADERS = AnalogFS.h Command.h CoreThread.h DataSettings.h DetectPal.h DialogBase.h \
 	DialogGroup.h DialogPeer.h HelpDialog.h LogSystem.h MainWindow.h ProgramData.h \
 	RecvFile.h RecvFileData.h RevisePal.h SendFile.h SendFileData.h ShareFile.h \

Reply via email to