tag 649513 + upstream
retitle 649513 xen-create-image does not check if parameter to device options 
are really devices
kthxbye

Hi,

Moonwalker wrote:
> Package: xen-tools
> Version: 4.2.1-1
> 
> xen-create-image --image-dev=/opt/root.img --swap-dev=/opt/swap.img ...
> creates a configuration file with the following disk options
> #
> #  Physical volumes
> #
> root        = '/dev/xvda2 ro'
> disk        = [
>     'phy:/opt/root.img,xvda2,w',
>     'phy:/opt/swap.img,xvda1,w',
> ]
> instead of "file" type partitions

Well, it does exactly what the docs say:

  --image-dev=/path/to/device
        Specify a physical/logical volume for the disk image.

  --swap-dev=/path/to/device
        Specify a physical/logical volume for swap usage.

It expects a device and not a file as parameter and hence writes a
config for a device.

The current way to use file based images is to use --dir. The files
will be named automatically based on the hostname.

I wonder what the ... options have been in the example. I suspect a
--dir in there.

I must admit that it though would be more helpful to the user if
xen-create-image would check if the given paths are really devices or
not and act accordingly (either by printing out a warning or, probably
better, to use files if the given path is no device or does not exist
(and --lvm is not given).

                Regards, Axel
-- 
 ,''`.  |  Axel Beckert <[email protected]>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
  `-    |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to