Dear Olly,
Olly Betts schrieb am 11.12.2011 14:31:
> On Sun, Dec 11, 2011 at 01:48:57PM +0100, Kai Wasserbäch wrote:
>> I've been busy packaging (or rather making fit for release) QApt, which
>> uses Xapian. Currently QApt and some other programs also using Qt (e.g.
>> packagesearch [0]) need to employ a workaround [1] to be able to use
>> both Qt and Xapian in conjunction. This is because both Qt and Xapian
>> have "slots".
> 
> Hmm, "slots" is a class member in Xapian.  Is Qt really defining "slots"
> as a pre-processor macro?  Haven't they heard of not polluting the
> global namespace?

I think they have, by now. I can only guess here, but as the slots stuff is one
of the older but still core parts of Qt, I suspect they didn't care _too_ much
back then. One can use Q_SLOTS today. But slots will still be there in the 
headers.

> And if so, why not just include xapian.h *first*?

I could do that too and can propose the required changes to QApt's upstream, but
I'd prefer, if both Xapian and Qt could be used alongside each other without
such requirements.

>> Hence I'd like to ask you to consider changing "slots" in keymaker.h
>> (and of course the other files including keymaker.h) to something
>> different. I know this would require some more work from the packages
>> using Xapian, but the amount seems way smaller than changing all Qt
>> packages.
> 
> I think that would mean an incompatible ABI change - if so, it certainly
> can't happen in the 1.2.x series.  

That'd be great. As you can see from the chosen severity, this is nothing I find
too pressing. It's just, that I suspect others might encounter this problem too
and in the long run it might be easier to just change one side. But this is
absolutely your call and if you prefer not to do this, then tag #651696 wontfix
and I forward the appropriate changes to QApt's upstream.

Kind regards,
Kai Wasserbäch



-- 

E-Mail: [email protected]
IRC: Curan
Jabber: [email protected]
URL: http://wiki.debian.org/C%C3%B9ran
GnuPG: 0xE1DE59D2      0600 96CE F3C8 E733 E5B6 1587 A309 D76C E1DE 59D2

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to