Carlos O'Donell made the following comments about bug 598937 and it's
associated patch on debian-arm. I am forwarding them to the bug report so
they are there for the next person who looks at it (be it me or someone else).

http://lists.debian.org/debian-arm/2011/12/msg00061.html

ISO C99 says that WCHAR_MAX must be a constant expression and the
above definition is such an expression. Technically the program needs
fixing (see below though for the "standards matter but so do users"),
there is nothing wrong with a type cast and a constant value e.g.
signed -1 converted to unsigned int (ARM GNU/Linux value for wchar_t).

However, the real issue here is that it differs from x86, the most
common architecture, and differences from x86 cause porting problems.
The patch itself is insufficient because it doesn't take into account
wordsize. When we switch to the 64-bit ARM ABI it should just work.
Therefore you need to check for __WORDSIZE and *only* define a value
if we are *not* 64-bits. You don't want to define anything for the
64-bit case until the 64-bit ARM ABI is out and finalized.




--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to