On Sat, Dec 17, 2011 at 09:28:17AM +0200, Niko Tyni wrote: > On Wed, Dec 14, 2011 at 11:30:54PM +0200, Niko Tyni wrote: > > On Sat, Aug 06, 2011 at 08:02:20PM +0200, [email protected] wrote: > > > > > while trying to get Embperl ready with Perl 5.14.1, I found an the > > > following message in the error log: > > > > > Attempt to free unreferenced scalar: SV 0x7fc218, Perl interpreter: > > > 0x7cfdb0 during global destruction. > > > > We're also seeing this in Debian now that we've switched to Perl 5.14, > > (see http://bugs.debian.org/650675 [cc'd.]) > > > The warnings only seem to happen with -Dusethreads, and I've bisected that > > they started with 5.13.6 - specifically > > > > > > http://perl5.git.perl.org/perl.git/commit/ca556bcdca736b2f85c11650c70b2371169c0225 > > > [perl #40389] perl_destruct() leaks PL_defstash > > > My limited understanding is that the CV pointer needs its refcount > > incremented along with the GvCV_set() call. See the attached proposed > > patch which fixes this for me (but feel free to tell me if I got it all > > wrong :) > > Here's another patch in a similar vein. This fixes all the remaining 24 > warnings in t/logs/error_log after running the whole test suite.
Incidentally it doesn't look like either of those messages made it as far as the modperl dev list, at least if <http://mail-archives.apache.org/mod_mbox/perl-dev/201112.mbox/browser> is to be believed. If it fixes the (extensive) test suite, it's probably a reasonable candidate for an upload to unstable, I'd have thought? Thanks for your work on this! Cheers, Dominic. -- Dominic Hargreaves | http://www.larted.org.uk/~dom/ PGP key 5178E2A5 from the.earth.li (keyserver,web,email) -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]

