Package: amide Version: 1.0.0-1 Severity: wishlist Tags: patch User: debian-...@lists.debian.org Usertags: ld-as-needed
when building amide with the linker flag --as-needed it is missing DCMTK support. This is caused by the use of LDFLAGS to define libraries to link with in configure.in. The correct autotools variable is LIBS or LDADD. Attached patch "DCMTK_support.patch" fixes the issue. PS: To build amide with dcmtk under as-needed also the underlinking of dcmtk must be fixed or -lpthread -lz must be added to LIBS of amide. see the second patch "missing-links.patch". It is not necessary when dcmtk is fixed.
Description: use correct autotools variables for libs
required to build with ld --as-needed
Author: Julian Taylor <jtay...@ubuntu.com>
Index: amide-1.0.0/configure.in
===================================================================
--- amide-1.0.0.orig/configure.in 2011-12-27 14:07:13.853875348 +0000
+++ amide-1.0.0/configure.in 2011-12-27 14:13:50.173874409 +0000
@@ -104,9 +104,9 @@
AMIDE_LIBDCMDATA_LIBS="-ldcmdata -lofstd -loflog -lavcodec -lavutil -lz $THREAD_LIBS"
AMIDE_LIBDCMDATA_CFLAGS="-I/usr/include/dcmtk/dcmdata"
dnl 2010.02.20 AMIDE_LIBDCMDATA_CFLAGS="-I/usr/local/dicom/include/dcmtk/dcmdata -I/usr/local/dicom/include/dcmtk/ofstd -I/usr/local/dicom/include -I/usr/include/dcmtk/dcmdata -I/usr/local/include/dcmtk/ofstd -I/sw/include/dcmtk/dcmdata -I/sw/include/dcmtk/ofstd -I/sw/include/dcmtk"
-saved_ldflags="${LDFLAGS}"
+saved_libs="${LIBS}"
saved_cxxflags="${CXXFLAGS}"
-LDFLAGS="${LDFLAGS} ${AMIDE_LIBDCMDATA_LIBS}"
+LIBS="${LIBS} ${AMIDE_LIBDCMDATA_LIBS}"
CXXFLAGS="${CXXFLAGS} ${AMIDE_LIBDCMDATA_CFLAGS} -DHAVE_CONFIG_H"
FOUND_DCMDATA=no
AC_LANG_CPLUSPLUS
@@ -116,7 +116,7 @@
])],
[FOUND_DCMDATA=yes],
[AC_MSG_WARN([libdcmdata was not found.])])
-LDFLAGS="${saved_ldflags}"
+LIBS="${saved_libs}"
CXXFLAGS="${saved_cxxflags}"
Index: amide-1.0.0/configure.in
===================================================================
--- amide-1.0.0.orig/configure.in 2011-12-27 14:21:07.913873377 +0000
+++ amide-1.0.0/configure.in 2011-12-27 14:21:18.973873345 +0000
@@ -101,7 +101,7 @@
dnl switch to C++ for DCMTK library stuff - also, if pthread is on the platform, probably need that
dnl autoconf doesn't have a nice macro for checking for c++ libraries, therefore the below:
AC_CHECK_LIB(pthread, pthread_mutex_init, THREAD_LIBS="-lpthread", THREAD_LIBS="")
-AMIDE_LIBDCMDATA_LIBS="-ldcmdata -lofstd -loflog -lavcodec -lavutil -lz $THREAD_LIBS"
+AMIDE_LIBDCMDATA_LIBS="-ldcmdata -lofstd -lpthread -lz -loflog -lavcodec -lavutil -lz $THREAD_LIBS"
AMIDE_LIBDCMDATA_CFLAGS="-I/usr/include/dcmtk/dcmdata"
dnl 2010.02.20 AMIDE_LIBDCMDATA_CFLAGS="-I/usr/local/dicom/include/dcmtk/dcmdata -I/usr/local/dicom/include/dcmtk/ofstd -I/usr/local/dicom/include -I/usr/include/dcmtk/dcmdata -I/usr/local/include/dcmtk/ofstd -I/sw/include/dcmtk/dcmdata -I/sw/include/dcmtk/ofstd -I/sw/include/dcmtk"
saved_libs="${LIBS}"
signature.asc
Description: OpenPGP digital signature
