Hello Rian & David,

while investigating a user problem we noticed that the wrapper doesn't
check the HTTP return code. Thus the program continues and usually fails
later during the GPG verification with an error messages that is very
difficult to understand for the end user (see
http://bugs.debian.org/651143 or
https://bugs.launchpad.net/ubuntu/+source/nautilus-dropbox/+bug/905223).
It can also fail sooner if the answer is lacking a Content-Length field
since you're trying to use that field even if it's not here (which in turn
leads to failures like those here:
https://bugs.launchpad.net/ubuntu/+source/nautilus-dropbox/+bug/846871).

In particular, if a proxy answers with 403 forbidden or something similar,
you should really fail early with an error message that better explains
the real underlying problem.

Cheers,
-- 
Raphaël Hertzog ◈ Writer/Consultant ◈ Debian Developer

Pre-order a copy of The Debian Administrator's Handbook and
help liberate it: http://debian-handbook.info/liberation/
--- Begin Message ---
reopen 651065
retitle 651065 'dropbox start -i' doesn't respect http_proxy as expected
severity 651065 important
clone 651065 -1
retitle -1 dropbox doesn't verify the HTTP return code when downloading the 
binaries 
thanks

On Mon, 05 Dec 2011, Teemu Ikonen wrote:
> I ran 'tsocks dropbox update' as root, so pkexec was probably not involved.

Right. So we probably still have the problem that I described.

> > Looking further I see that the message you pasted says “Downloading
> > Dropbox... 100%” so the download actually worked but only the
> > download of the signature failed (or worked but returned nothing).
> 
> The failure was instantaneous, so the client was not downloaded. The
> downloader script probably mistook the '403 forbidden' message as a
> success.

Indeed, you're right. Yet another bug in the implementation... that also
explains why I have seen many errors where the failure involved the lack
of a Content-Length field in the answer. Probably a proxy that did not put
this field in its answer...

Cloning into a new bug for this one.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Pre-order a copy of the Debian Administrator's Handbook and help
liberate it: http://debian-handbook.info/liberation/




--- End Message ---

Reply via email to