Package: gitolite
Version: 2.2-1
Severity: wishlist
Tags: patch
gl-setup contains last line:
[ -n "$pubkey_file" ] && $GL_BINDIR/sshkeys-lint <
$HOME/.ssh/authorized_keys -q -a $admin_name
=================
Huh? Nobody writes redirection like that in the middle of call: Please
use readable:
[ -n "$pubkey_file" ] && $GL_BINDIR/sshkeys-lint -q -a $admin_name <
$HOME/.ssh/authorized_keys
===================
See attached patch.
>From 80c05d4d9b7934c891c9ea2a5aec04eb6f758f71 Mon Sep 17 00:00:00 2001
From: Jari Aalto <[email protected]>
Date: Mon, 2 Jan 2012 02:21:00 +0200
Subject: [PATCH] gl-setup: (sshkeys-lint): Move file redirection to the end
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Signed-off-by: Jari Aalto <[email protected]>
---
gl-setup | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gl-setup b/gl-setup
index 3ce8827..f77de98 100755
--- a/gl-setup
+++ b/gl-setup
@@ -141,4 +141,4 @@ gl-install -q
# the never-ending quest to help with bloody ssh issues...
cd $GL_ADMINDIR/keydir
-[ -n "$pubkey_file" ] && $GL_BINDIR/sshkeys-lint < $HOME/.ssh/authorized_keys
-q -a $admin_name
+[ -n "$pubkey_file" ] && $GL_BINDIR/sshkeys-lint -q -a $admin_name <
$HOME/.ssh/authorized_keys
--
1.7.7.3
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (990, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.38-2-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=ANSI_X3.4-1968)
(ignored: LC_ALL set to C)
Shell: /bin/sh linked to /bin/dash
Versions of packages gitolite depends on:
ii adduser 3.113
ii debconf [debconf-2.0] 1.5.41
ii git [git-core] 1:1.7.7.3-1
ii git-core 1:1.7.7.3-1
ii openssh-server 1:5.9p1-2
ii perl 5.14.2-6
gitolite recommends no packages.
Versions of packages gitolite suggests:
ii git-daemon-run 1:1.7.7.3-1
ii gitweb 1:1.7.7.3-1
-- debconf information excluded
-- debsums errors found:
debsums: changed file /usr/share/gitolite/gl-setup (from gitolite package)
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
