Package: lazr.restfulclient
Version: 0.12.0-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu precise ubuntu-patch
Hi,
setup.py includes some test dependencies in the requires list, but they
aren't in the package dependencies. This leads to a broken package from
setuptools' point of view, and so breaks some code that uses
launchpadlib and pkg_resources together.
Thanks,
James
*** /tmp/tmpkp34Jl
In Ubuntu, the attached patch was applied to achieve the following:
## ---------------- REPLACE THIS WITH ACTUAL INFORMATION ---------------------
## Please add all necessary information about why the change needed to go in
## Ubuntu, quote policy, spec or any other background material and why it can
## and should be used in Debian too. If the patch is composed of multiple
## independent pieces, please send them as separate bug reports.
## ---------------- REPLACE THIS WITH ACTUAL INFORMATION ---------------------
* Move test dependencies to extras_require so that setuptools doesn't think
they are needed for the code to work. (LP: #918307)
.
Having them listed in requires, but not in the package dependencies leads
to having a package installed that setuptools thinks is broken. This
breaks any code that relies on lazr.restfulclient (or launchpadlib) and
uses setuptools/pkg_resources.
Thanks for considering the patch.
-- System Information:
Debian Release: wheezy/sid
APT prefers oneiric-updates
APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500,
'oneiric-proposed'), (500, 'oneiric'), (100, 'oneiric-backports')
Architecture: amd64 (x86_64)
Kernel: Linux 3.0.0-14-generic (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
=== added file 'debian/patches/remove_test_requires.patch'
--- debian/patches/remove_test_requires.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/remove_test_requires.patch 2012-01-18 17:52:29 +0000
@@ -0,0 +1,54 @@
+Index: precise/setup.py
+===================================================================
+--- precise.orig/setup.py 2012-01-18 12:51:43.340419673 -0500
++++ precise/setup.py 2012-01-18 12:52:02.884420120 -0500
+@@ -56,11 +56,9 @@
+ license='LGPL v3',
+ install_requires=[
+ 'httplib2',
+- 'lazr.authentication',
+ 'oauth',
+ 'setuptools',
+ 'wadllib>=1.1.4',
+- 'wsgi_intercept',
+ ],
+ url='https://launchpad.net/lazr.restfulclient',
+ download_url= 'https://launchpad.net/lazr.restfulclient/+download',
+@@ -73,8 +71,12 @@
+ extras_require=dict(
+ docs=['Sphinx',
+ 'z3c.recipe.sphinxdoc'],
+- test=['lazr.restful>=0.11.0',
+- 'van.testing'],
++ test=[
++ 'lazr.authentication',
++ 'lazr.restful>=0.11.0',
++ 'wsgi_intercept',
++ 'van.testing'
++ ],
+ ),
+ test_suite='lazr.restfulclient.tests',
+ )
+Index: precise/src/lazr.restfulclient.egg-info/requires.txt
+===================================================================
+--- precise.orig/src/lazr.restfulclient.egg-info/requires.txt 2012-01-18
12:52:13.776420367 -0500
++++ precise/src/lazr.restfulclient.egg-info/requires.txt 2012-01-18
12:52:23.396420590 -0500
+@@ -1,14 +1,14 @@
+ httplib2
+-lazr.authentication
+ oauth
+ setuptools
+ wadllib>=1.1.4
+-wsgi_intercept
+
+ [test]
++lazr.authentication
+ lazr.restful>=0.11.0
+ van.testing
++wsgi_intercept
+
+ [docs]
+ Sphinx
+-z3c.recipe.sphinxdoc
+\ No newline at end of file
++z3c.recipe.sphinxdoc
=== modified file 'debian/patches/series'
--- debian/patches/series 2011-08-11 18:30:05 +0000
+++ debian/patches/series 2012-01-18 17:51:35 +0000
@@ -1 +1,2 @@
no_package_data.patch
+remove_test_requires.patch
