On Sun, Jan 22, 2012 at 01:22, Jakub Wilk <jw...@debian.org> wrote:
> Thanks for looking into this!
>
> * Sandro Tosi <mo...@debian.org>, 2012-01-22, 00:53:
>
>> I've looked into this issue, and it's not about translations.js
>
>
> Right, it's only a warning about translations.js.
>
> In theory we _could_ move translations to the libjs-* package and then
> symlink them too, but this is probably too much hassle for very little
> benefit.

if translates.js is the same for all the projects using sphinx then it
probably makes sense to symlink it, but it's also true that there's
only one occurrence of translate.js in all debian packages, so
probably we can also wait and see how the situation evolves.

> But it we decide that not symlinking translations.js is by design, then we
> should also silence the warning.

that too, or differentiate the warning and error messages (that are
now the same, which could be a bit misleading).

>> but about searchtools.js: given virtualenvwrapper provides multi-language
>> doc, sphinx generates a searchtools.js that might be different for some
>> langs, and in this case Japanese generates a searchtools that is different
>> from the reference copy in
>> /usr/share/javascript/sphinxdoc/1.0/searchtools.js. I'm attaching a diff in
>> case it might help.
>>
>> It seems there could be 2 versions of searchtools.js: one for langs with
>> stemming rules and another without them.
>
>
> Actually, we should have 3 versions of searchtools.js: one for the English
> stemmer, one for the Japanese stemmer, and one without stemming rules.
>
>> --- /usr/share/javascript/sphinxdoc/1.0/searchtools.js  2011-11-20
>> 20:17:32.000000000 +0100
>> +++
>> debian/virtualenvwrapper/usr/share/doc/virtualenvwrapper/ja/html/_static/searchtools.js
>>     2012-01-22 00:40:37.435086642 +0100
>> @@ -38,183 +38,10 @@
>>
>>
>> /**
>> - * Porter Stemmer
>> + * Dummy stemmer for languages without stemming rules.
>>  */
>> var Stemmer = function() {
>
>
> This is odd. It should be Japanese stemmer here, not the generic one. Smells
> like another bug.

but sphinx/search/ja.py doesn't define any js_stemmer_code so it uses
the default implementation in __init__.py which is the dummy one.

-- 
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to