OoO  En ce début  d'après-midi nuageux  du mardi  17 janvier  2012, vers
14:48, Andreas Beckmann <[email protected]> disait :

> during a test with piuparts I noticed your package left unowned files on
> the system after purge, which is a violation of policy 6.8 (or 10.8):

> http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails

> Filing this as important as having a piuparts clean archive is a release
> goal since lenny.

>> From the attached log (scroll to the bottom...):

> 0m19.6s ERROR: FAIL: Package purging left files on system:
>   /var/log/sesman.log not owned

OK for this one.

> During a test with piuparts I noticed your package failed to purge due to a
> command not found. According to policy 7.2 you cannot rely on the depends
> being available during purge, only the essential packages are available for
> sure.

> Filing this as important because a.) it's a clear policy violation (to not
> clean up at purge) b.) having a piuparts clean archive is a release goal
> since lenny and c.) this package being piuparts buggy blocks packages
> depending on it from being tested by piuparts (and thus possibly the
> detection of more severe problems).

>> From the attached log (scroll to the bottom...):

> The fix should be easy: your package is using adduser or deluser from the
> adduser package, which is only priority important. Using useradd or userdel
> from the passwd package should fix this problem.

>   Removing xrdp ...
>   Purging configuration files for xrdp ...
>   /var/lib/dpkg/info/xrdp.postrm: 18: /var/lib/dpkg/info/xrdp.postrm: 
> deluser: not found
>   /var/lib/dpkg/info/xrdp.postrm: 19: /var/lib/dpkg/info/xrdp.postrm: 
> delgroup: not found

Not OK  for this  one. deluser and  delgroup provides the  --system flag
that ensure that the group or user  is deleted only if it was created as
a system group or user.

For example,  a user install xrdp  with a user  "xrdp" already existing.
It then purges  the package.  The user xrdp should  not be removed. This
is not something easily achieved with userdel and groupdel.

I am fixing the first part. If you want to keep the second issue, I will
clone this bug.
-- 
Vincent Bernat ☯ http://vincent.bernat.im

Identify bad input; recover if possible.
            - The Elements of Programming Style (Kernighan & Plauger)

Attachment: pgpKQmpq5E8KD.pgp
Description: PGP signature

Reply via email to