Hi there! Stupid bug, really -- considering there are over 500 break statements in gtkpod, the ratio is not too bad however ;-)
I've fixed it and will commit to CVS later. Cheers, JCS. P.S.: package maintainer: the next gtkpod release will depend on the new libgpod library (www.gtkpod.org). On Sun, Sep 25, 2005 at 09:20:47PM +0200, Flavio Stanchina wrote: > Package: gtkpod > Version: 0.94.0-1 > Severity: normal > Tags: patch > > Sort by size and by track length doesn't work: classic bug, two missing > break statements in a switch... Patch is attached. > > -- System Information: > Debian Release: testing/unstable > Architecture: i386 (i686) > Shell: /bin/sh linked to /bin/bash > Kernel: Linux 2.6.13.2-athlon > Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) > > Versions of packages gtkpod depends on: > ii libatk1.0-0 1.10.3-1 The ATK accessibility toolkit > ii libc6 2.3.5-6 GNU C Library: Shared libraries > an > ii libglade2-0 1:2.5.1-2 library to load .glade files at > ru > ii libglib2.0-0 2.8.0-1 The GLib library of C routines > ii libgtk2.0-0 2.6.4-3 The GTK+ graphical user > interface > ii libid3tag0 0.15.1b-4.1 ID3 tag reading library from the > M > ii libpango1.0-0 1.8.2-2 Layout and rendering of > internatio > ii libxml2 2.6.22-1 GNOME XML library > ii zlib1g 1:1.2.3-4 compression library - runtime > --- src/display_songs.c-orig 2005-09-25 21:02:10.000000000 +0200 > +++ src/display_songs.c 2005-09-25 21:13:28.000000000 +0200 > @@ -1658,8 +1658,10 @@ > break; > case TM_COLUMN_SIZE: > cmp = track1->size - track2->size; > + break; > case TM_COLUMN_TRACKLEN: > cmp = track1->tracklen - track2->tracklen; > + break; > case TM_COLUMN_BITRATE: > cmp = track1->bitrate - track2->bitrate; > break; -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
