Package: sysfsutils
Version: 2.1.0+repack-1
Severity: normal

Hey,

right now sysfsutils only support tuning file permissions, there's a check in
/etc/init.d/sysfsutils:

if [ -f "/sys/$f2" ]; then
    chmod "$f3" "/sys/$f2"
else
    log_failure_msg "unknown attribute $f2"
fi

Would you consider switching to: [ -f "/sys/$f2" ] || [ -d "/sys/$f2" ]
or something similar?

Regards,
-- 
Yves-Alexis

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-1-grsec-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages sysfsutils depends on:
ii  libc6      2.13-25
ii  libsysfs2  2.1.0+repack-1

sysfsutils recommends no packages.

sysfsutils suggests no packages.

-- Configuration Files:
/etc/init.d/sysfsutils changed:
set -x
CONFFILE=/etc/sysfs.conf
[ -r "$CONFFILE" ] || exit 0
.. /lib/lsb/init-functions
case "$1" in
    start|restart|force-reload)
        log_begin_msg "Setting sysfs variables..."
        sed  's/#.*$//; /^[[:space:]]*$/d; 
              
s/^[[:space:]]*\([^=[:space:]]*\)[[:space:]]*\([^=[:space:]]*\)[[:space:]]*=[[:space:]]*\(.*\)/\1
 \2 \3/' \
              $CONFFILE | {
            while read f1 f2 f3; do
                if [ "$f1" = "mode" -a -n "$f2" -a -n "$f3" ]; then
                    if [ -f "/sys/$f2" ]; then
                        chmod "$f3" "/sys/$f2"
                    else
                        log_failure_msg "unknown attribute $f2"
                    fi
                elif [ "$f1" = "owner" -a -n "$f2" -a -n "$f3" ]; then
                    if [ -f "/sys/$f2" ]; then
                        chown "$f3" "/sys/$f2"
                    else
                        log_failure_msg "unknown attribute $f2"
                    fi
                elif [ "$f1" -a -n "$f2" -a -z "$f3" ]; then
                    if [ -f "/sys/$f1" ]; then
                        # Some fields need a terminating newline, others
                        # need the terminating newline to be absent :-(
                         echo -n "$f2" > "/sys/$f1" 2>/dev/null ||
                            echo "$f2" > "/sys/$f1"
                    else
                        log_failure_msg "unknown attribute $f1"
                    fi
                else
                    log_failure_msg "syntax error in $CONFFILE: '$f1' '$f2' 
'$f3'"
                    log_end_msg 1
                    exit 1
                fi
            done
        }
        log_end_msg 0
        ;;
    stop)
        ;;
    *)
        echo "Usage: /etc/init.d/sysfsutils {start|stop|force-reload|restart}"
        exit 1
        ;;
esac

/etc/sysfs.conf changed:
  
mode . = 0755


-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to