On Wed, Feb 08, 2012 at 11:56:01PM +0200, jaalto wrote: > On 2012-02-08 21:45, Adam D. Barratt wrote: > | On Wed, 2012-02-08 at 02:58 -0500, Jari Aalto wrote: > | > The following patch updates to use POSIX[1] command substitution $() in > | > place of backtics (``). > | > > | > Motivation: > | > > | > - Recommended practise. The $() is recommend by many[2]. It nests easily. > | > - Readability. In high resolution display a "tick" is hard to see. > | > Different font may also make reading the "tick" difficult to > distinguish. > | > - Typing convenience. The backtick key may be placed in difficult > | > position in non-US keyboard. E.g acrobatics is needed with FI-keyboard > | > by pressing three keys in succession: AltGr + key + Space char > | > | I'm confused as to how either the first or last of the above makes any > | difference to _code that already exists_, which is what you're > | suggesting changing. > > Maintenance. It's a good idea to keep refactoring also old code in the > spirit of XP.
I prefer the "If it ain't broke, don't fix it" approach. Any code change, no matter how trivial, risks introducing a bug. From a quick glance at the patch, it appears to be correct, but I don't see the value in making this change for purely aesthetic reasons. If and when we have legitimate reasons to change code in the relevant areas, we can see about changing from backticks to $(). -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <james...@debian.org>
signature.asc
Description: Digital signature
