Package: freeciv-client-gtk
Version: 2.3.1-1
Severity: wishlist
Tags: patch

Hello,

the citizen manager currently has one flaw: One cannot reduce the minimum
required gold/food/production units below -20, which sometimes is insufficient.
As a result, the CMA refuses to manage the city if it cannot get above -20 gold
per turn, even if the associated factor is set to 0.

This might be feasible, for example, when one is currently building a city with
lots of improvements which is not yet big enough to produce enough trade, but
the rest of your empire can easily support this one city losing gold.

One can avoid this problem by manually adding pre-set CMAs to the ~/.freeciv-
client-rc-2.3, but this is tedious.

The attached patch increases/decreases the minima and maxima in the GTK client
to -200 and +200, respectively.

I would be very thankful if you could think about applying it :)

Best regards,

Claudius



-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable-updates'), (500, 'unstable'), 
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.1.a2017.2 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages freeciv-client-gtk depends on:
ii  freeciv-data        2.3.1-1
ii  ggzcore-bin         0.0.14.1-1.1
ii  libatk1.0-0         2.2.0-2
ii  libbz2-1.0          1.0.6-1
ii  libc6               2.13-24
ii  libcairo2           1.10.2-6.2
ii  libfontconfig1      2.8.0-3.1
ii  libfreetype6        2.4.8-1
ii  libgdk-pixbuf2.0-0  2.24.0-2
ii  libglib2.0-0        2.30.2-4
ii  libgtk2.0-0         2.24.8-3
ii  libpango1.0-0       1.29.4-2
ii  libsdl-mixer1.2     1.2.12-1
ii  libsdl1.2debian     1.2.15-1
ii  zlib1g              1:1.2.3.4.dfsg-3

Versions of packages freeciv-client-gtk recommends:
ii  freeciv-server  2.3.1-1

Versions of packages freeciv-client-gtk suggests:
ii  freeciv-sound-standard [freeciv-sound]  2.3.1-1

-- no debconf information
Description: Increases minima and maxima in CMA to +-500
 This patch increases the minima and maxima settable in the CMA to
 +-500.
Author: Claudius Hubig <claudiushu...@chubig.net>
Forwarded: no
Last-Update: <2012-02-12>

--- freeciv-2.3.1.orig/client/gui-gtk-2.0/cma_fe.c
+++ freeciv-2.3.1/client/gui-gtk-2.0/cma_fe.c
@@ -331,7 +331,7 @@ struct cma_dialog *create_cma_dialog(str
     gtk_misc_set_alignment(GTK_MISC(label), 0, 0.5);
 
     pdialog->minimal_surplus[i] =
-	GTK_ADJUSTMENT(gtk_adjustment_new(-20, -20, 20, 1, 1, 0));
+	GTK_ADJUSTMENT(gtk_adjustment_new(-200, -200, 200, 1, 1, 0));
 
     hscale = gtk_hscale_new(GTK_ADJUSTMENT(pdialog->minimal_surplus[i]));
     gtk_table_attach_defaults(GTK_TABLE(table), hscale, 1, 2, i + 1, i + 2);

Reply via email to