Package: buildbot-slave
Version: 0.8.5-1.1
Severity: wishlist

Hello,

This wishlist actually masters for both buildbot slave and master
but the patch is almost the same so I am reporting a single bug.

I'd like /etc/init.d/buildslave <cmd> to accept an additional
parameter that specify which slave to operate on. This is useful
for:
* manually enabling a slave that's disabled in the config file
* restarting a slave when it's config was modified without
  modifying all others (more important for masters)

Obviously, I can do this by running buildslave restart $PATH
but you have to remember the path to do so, and it's not so
easy when you have tons of slaves on the machine and/or
different paths depending on the machine.

Thanks
Brice

--- /etc/init.d/buildslave.old  2012-02-24 09:08:34.000000000 +0100
+++ /etc/init.d/buildslave      2012-02-24 08:57:50.599256000 +0100
@@ -113,7 +113,10 @@
 function do_op () {
     errors=0
     for i in $( seq ${#SLAVE_ENABLED[@]} ); do
-        if is_disabled "${SLAVE_ENABLED[$i]}" ; then
+       if test x"$4" != x -a x"$4" != x"${SLAVE_NAME[$i]}" ; then
+            continue
+        fi
+        if is_disabled "${SLAVE_ENABLED[$i]}" && test x"$4" = x ; then
             continue
         fi
 
@@ -140,19 +143,19 @@
 
 case "$1" in
     start)
-        do_op "slave_op" "start" "Starting buildslave"
+        do_op "slave_op" "start" "Starting buildslave" "$2"
         exit $?
         ;;
     stop)
-        do_op "slave_op" "stop" "Stopping buildslave"
+        do_op "slave_op" "stop" "Stopping buildslave" "$2"
         exit $?
         ;;
     reload)
-        do_op "slave_op" "reload" "Reloading buildslave"
+        do_op "slave_op" "reload" "Reloading buildslave" "$2"
         exit $?
         ;;
     restart|force-reload)
-        do_op "slave_op" "restart" "Restarting buildslave"
+        do_op "slave_op" "restart" "Restarting buildslave" "$2"
         exit $?
         ;;
     *)


-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages buildbot-slave depends on:
ii  adduser               3.113+nmu1
ii  python                2.7.2-10
ii  python-twisted-core   11.1.0-1
ii  python-twisted-words  11.1.0-1
ii  python2.6             2.6.7-4
ii  python2.7             2.7.2-13

buildbot-slave recommends no packages.

Versions of packages buildbot-slave suggests:
ii  buildbot        0.8.5-1.1
ii  cvs             2:1.12.13+real-8
ii  git [git-core]  1:1.7.9-1
ii  git-core        1:1.7.9-1
ii  mercurial       2.1-1
ii  subversion      1.6.17dfsg-3

-- Configuration Files:
/etc/default/buildslave changed [not included]
/etc/init.d/buildslave changed [not included]

-- no debconf information



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to