Package: libnfsidmap Version: 0.25-1 Severity: important Tags: patch User: [email protected] Usertags: origin-ubuntu precise ubuntu-patch
Hi Anibal, In <https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/939232>, a user has reported that umich_ldap is not working with version 0.25-1 of libnfsidmap in Ubuntu. I've confirmed that this is due to a bug present upstream in libnfsidmap 0.25: a wrong check for ENABLE_LDAP in umich_ldap.c causes the module to be linked as an empty module. The attached patch which corrects the issue has been uploaded to Ubuntu. Please consider applying it to the Debian package and forwarding it upstream. Thanks, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ [email protected] [email protected]
=== added directory 'debian/patches' === added file 'debian/patches/series' --- debian/patches/series 1970-01-01 00:00:00 +0000 +++ debian/patches/series 2012-02-25 06:19:38 +0000 @@ -0,0 +1 @@ +wrong-double-ldap-check.patch === added file 'debian/patches/wrong-double-ldap-check.patch' --- debian/patches/wrong-double-ldap-check.patch 1970-01-01 00:00:00 +0000 +++ debian/patches/wrong-double-ldap-check.patch 2012-02-25 06:21:29 +0000 @@ -0,0 +1,26 @@ +Author: Steve Langasek <[email protected]> +Description: Don't check ENABLE_LDAP twice + This source is already being conditionally compiled based on ENABLE_LDAP + being set in the Makefile. All this extra check does is cause umich_ldap.so + to always be compiled as an *EMPTY* object because nothing sets ENABLE_LDAP + before the #ifdef! +Bug-Ubuntu: https://bugs.launchpad.net/bugs/939232 + +Index: libnfsidmap/umich_ldap.c +=================================================================== +--- libnfsidmap.orig/umich_ldap.c ++++ libnfsidmap/umich_ldap.c +@@ -32,8 +32,6 @@ + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +-#ifdef ENABLE_LDAP +- + #include <sys/types.h> + #include <sys/socket.h> + #include <netdb.h> +@@ -1302,4 +1300,3 @@ + { + return (&umichldap_trans); + } +-#endif
