On 2012-02-25 10:24, Raphael Hertzog wrote:
| Hello,
|
| On Sat, 25 Feb 2012, Jari Aalto wrote:
| > I've attached 90_fix_makefiles.patch for further study.
| >
| > dpkg reports during build:
| [...]
| > dpkg-source: info: applying
04_fix_bug_380210_fix_export_and_export_utils_detection.patch
| > dpkg-source: error: expected [ +-] at start of line 45 of diff
`easychem.git/debian/patches/90_fix_makefiles.patch'
|
| This doesn't mean anything (quilt/patch are lenient and accept slightly
| incorrect input) and dpkg-source is right. Line 45 of the file starts
| with a TAB instead of a space.
|
| It should be space + TAB (since the TAB is the start of the content).
|
| > clean: FORCE
| > -cd graph; make clean
| > @@ -38,21 +39,21 @@
| > -rm $(OBJECTS) easychem
|
| Those are the bad lines.
Well, dpkg can be stricter, but it would be much better if:
- Dpkg accepted what can be don with quilt(1)
- Wrote a warning instead of spooing with error.
After all, we manage patched with quilt, and if we can aply/deapply
them with it, so should dpkg during building packages[*[.
Jari
[*] with format "3.0 quilt"
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
