On Tue, 2012-02-28 at 11:06 -0400, Joey Hess wrote: > > It seems reasonable to just leave the version out, on the grounds that > it's unlikely to be useful information and that repeatable builds are > a nice feature to have when easily possible. > > Want to respin the patch?
Attached. -- bye, pabs http://wiki.debian.org/PaulWise
From b45aa65654e733f864fe3969707108fc5477566e Mon Sep 17 00:00:00 2001 From: Paul Wise <[email protected]> Date: Tue, 28 Feb 2012 23:14:20 +0800 Subject: [PATCH] Drop the version attribute on the generator tag in Atom feeds. Removing the version means that rebuilds are reproducible over time. Both the generator tag and its version attribute are optional: http://tools.ietf.org/html/rfc4287#section-4.2.4 --- IkiWiki/Plugin/inline.pm | 1 - templates/atompage.tmpl | 2 +- 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/IkiWiki/Plugin/inline.pm b/IkiWiki/Plugin/inline.pm index 159cc5d..bdab579 100644 --- a/IkiWiki/Plugin/inline.pm +++ b/IkiWiki/Plugin/inline.pm @@ -677,7 +677,6 @@ sub genfeed ($$$$$@) { guid => $guid, feeddate => date_3339($lasttime), feedurl => $feedurl, - version => $IkiWiki::version, ); run_hooks(pagetemplate => sub { shift->(page => $page, destpage => $page, diff --git a/templates/atompage.tmpl b/templates/atompage.tmpl index e82b598..3cdd71d 100644 --- a/templates/atompage.tmpl +++ b/templates/atompage.tmpl @@ -33,7 +33,7 @@ <id><TMPL_VAR PAGEURL></id> </TMPL_IF> <subtitle type="html"><TMPL_VAR FEEDDESC ESCAPE=HTML></subtitle> -<generator uri="http://ikiwiki.info/"; version="<TMPL_VAR VERSION>">ikiwiki</generator> +<generator uri="http://ikiwiki.info/";>ikiwiki</generator> <updated><TMPL_VAR FEEDDATE></updated> <TMPL_VAR CONTENT> </feed> -- 1.7.9
signature.asc
Description: This is a digitally signed message part
