On 12 March 2012 23:41, Andres Mejia <amejia...@gmail.com> wrote:

> On Fri, Mar 9, 2012 at 12:34 PM, Savvas Radevic <vice...@gmail.com> wrote:
> >> I rather have a patch to libarchive's build system that sets '-v'
> >> option for all test programs.
> >
> >
> > I'll read the code and see if I can come up with something.
> >
> >>
> >> Also, next time, please don't include unrelated changes in your
> >> patches (I'm referring to the use of '-').
> >
> >
> > '-' ignores the exit status, that was deliberately put there - I thought
> > that the dh_auto_test returns an exit code 2, e.g. the mipsel build:
> >
> https://buildd.debian.org/status/fetch.php?pkg=libarchive&arch=mipsel&ver=3.0.3-6&stamp=1330969393
> >
> > =====================================
> > make[4]: *** [check-TESTS] Error 1
> > 1 of 3 tests failed
> > Please report to kient...@freebsd.org
> > =====================================
> > make[4]: Leaving directory
> > `/build/buildd-libarchive_3.0.3-6-mipsel-znTD6e/libarchive-3.0.3'
> > make[3]: *** [check-am] Error 2
> > make[3]: Leaving directory
> > `/build/buildd-libarchive_3.0.3-6-mipsel-znTD6e/libarchive-3.0.3'
> > make[2]: *** [check] Error 2
> > make[2]: Leaving directory
> > `/build/buildd-libarchive_3.0.3-6-mipsel-znTD6e/libarchive-3.0.3'
> > dh_auto_test: make -j2 check returned exit code 2
> > make[1]: *** [override_dh_auto_test] Error 29
> > make[1]: Leaving directory
> > `/build/buildd-libarchive_3.0.3-6-mipsel-znTD6e/libarchive-3.0.3'
> > make: *** [build] Error 2
> > dpkg-buildpackage: error: debian/rules build gave error exit status 2
> >
> > If the tests fail, it won't execute the commands that follow after
> > dh_auto_test.
> > Another example:
> >
> > $ cat Makefile
> > test:
> >     exit 2
> >     echo "hello world"
> >
> > $ make -f Makefile test
> > exit 2
> > make: *** [test] Error 2
>
> The exit status should not be ignored. In the above case, I would have
> preferred
> $ test dh_auto_test --parallel || ...do something here...
>
> In any case, I prefer something to the build system that optionally
> passes '-v' to the test programs. If you are going to come up with
> something, note that libarchive can use two build systems, autotools
> and cmake.
>
> --
> ~ Andres
>


I've tried to use cmake as a buildsystem, but I have two problems:
a) there's not .pc file
b) I think there's no variable for me to change output libdir to lib
multiarch

Attachment: use_cmake.debdiff
Description: Binary data

Reply via email to