tags: patch

>Some more info:
><jcdubacq> pbuilder does that:DPKG_COMMANDLINE="dpkg-buildpackage -us -uc 
>${DEBEMAIL:+\"-e$DEBEMAIL\"} $DEBBUILDOPTS"
><jcdubacq> whereas it should do that: DPKG_COMMANDLINE="dpkg-buildpackage -us 
>-uc ${DEBEMAIL:+${DEBFULLNAME:+\"-e$DEBFULLNAME <$DEBEMAIL>\"}} $DEBBUILDOPTS"
><jcristau> jcdubacq: no it should not use that at all
><jcdubacq> some hours ago, I was told DEBEMAIL should be only the address
><jcristau> correct.
><jcdubacq> if only the address is in DEBEMAIL, lintian says 
>changed-by-name-missing
><jcristau> but there's no reason for pbuilder to use dpkg-buildpackage -e
>
>That makes sense: with no args, dpkg-buildpackage does the right thing
>if DEBEMAIL is set and DEBFULLNAME is set.
>So let the work be done by dpkg-buildpackage.

Hello

Any updates on this? As stated in the previous comment in this bug
report dpkg-buildpackage does the right thing without parameters. I
have used the attached trivial patch and reapplied after every upgrade
to the package for almost 2 years and it works fine.

Hope this helps,
Miguel
--- /usr/lib/pbuilder/pbuilder-buildpackage.orig	2011-01-21 14:34:39.000000000 -0500
+++ /usr/lib/pbuilder/pbuilder-buildpackage	2011-01-21 14:35:26.000000000 -0500
@@ -122,7 +122,7 @@
 
 executehooks "A"
 
-DPKG_COMMANDLINE="env PATH=\"$PATH\" dpkg-buildpackage -us -uc ${DEBEMAIL:+\"-e$DEBEMAIL\"} $DEBBUILDOPTS"
+DPKG_COMMANDLINE="env PATH=\"$PATH\" dpkg-buildpackage -us -uc $DEBBUILDOPTS"
 
 (
     : Build process

Reply via email to