Your message dated Fri, 09 Sep 2005 20:45:21 -0400
with message-id <[EMAIL PROTECTED]>
has caused the Debian Bug report #325924,
regarding mirrordir: implicitly converted pointers
to be marked as having been forwarded to the upstream software
author(s) [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED]
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
---------------------------------------
Received: (at 325924-forwarded) by bugs.debian.org; 10 Sep 2005 00:46:10 +0000
>From [EMAIL PROTECTED] Fri Sep 09 17:46:09 2005
Return-path: <[EMAIL PROTECTED]>
Received: from sccrmhc14.comcast.net [63.240.76.49]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EDtVR-0000H7-00; Fri, 09 Sep 2005 17:46:09 -0700
Received: from vanzandt.comcast.net
(c-24-61-94-90.hsd1.nh.comcast.net[24.61.94.90](misconfigured sender))
by comcast.net (sccrmhc14) with ESMTP
id <2005091000453601400ekvcfe>; Sat, 10 Sep 2005 00:45:37 +0000
Received: from jrv by vanzandt.comcast.net with local (Exim 3.36 #1 (Debian))
id 1EDtUf-0001Jy-00; Fri, 09 Sep 2005 20:45:21 -0400
To: [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED]
Subject: [EMAIL PROTECTED]: Bug#325924: mirrordir: implicitly converted
pointers]
Message-Id: <[EMAIL PROTECTED]>
From: "James R. Van Zandt" <[EMAIL PROTECTED]>
Date: Fri, 09 Sep 2005 20:45:21 -0400
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-11.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER,
HAS_PACKAGE autolearn=ham version=2.60-bugs.debian.org_2005_01_02
Paul -
One of the Debian autobuilders detected some apparent pointer/integer
confusion in mirrordir sources. I did a scan of the code:
cd /usr/local/src/mirrordir/mirrordir-0.10.49/
find . -type f|xargs grep -n -e retrieve_link /dev/null
./src/hardlink.c:184:char *retrieve_link (void)
./src/tar.c:270: arch_linkname = (char *) strdup ((char *) retrieve_link
());
Binary file ./src/hardlink.o matches
...
It looks like there is no declaration of retrieve_link in tar.c or any
header file, so when compiling tar.c gcc assumes the default
declaration instead. I suggest the following change:
--- mirrordir.h-orig 2005-09-08 21:29:53.000000000 -0400
+++ mirrordir.h 2005-09-08 21:30:13.000000000 -0400
@@ -79,6 +79,7 @@
void reduce_hardlink (void);
void create_link (char *q);
void free_all_hardlinks (void);
+char *retrieve_link (void);
unsigned long mode_t_to_unsigned_long (mode_t m);
int parse_permissions_command (char *p, unsigned long *mask);
- Jim Van Zandt
------- Start of forwarded message -------
X-Originating-IP: [140.211.166.43]
X-Loop: [EMAIL PROTECTED]
Subject: Bug#325924: mirrordir: implicitly converted pointers
Reply-To: dann frazier <[EMAIL PROTECTED]>, [EMAIL PROTECTED]
Resent-From: dann frazier <[EMAIL PROTECTED]>
Resent-To: [email protected]
Resent-CC: [EMAIL PROTECTED] (James R. Van Zandt)
X-Debian-PR-Message: report 325924
X-Debian-PR-Package: mirrordir
X-Debian-PR-Keywords: patch
From: dann frazier <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Cc: David Mosberger <[EMAIL PROTECTED]>
Date: Wed, 31 Aug 2005 14:02:17 -0600
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at ldl.fc.hp.com
Resent-Sender: Debian BTS <[EMAIL PROTECTED]>
X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on
vanzandt.comcast.net
X-Spam-Level:
X-Spam-Status: No, score=0.1 required=6.0 tests=FORGED_RCVD_HELO
autolearn=unavailable version=3.0.4
Package: mirrordir
Version: 0.10.49-intl-1.1
Severity: important
Tags: patch
Our automated buildd log filter[1] detected a problem[2] that will cause
your package to segfault on architectures where the size of a pointer is
greater than the size of an integer, such as ia64.
[1]http://people.debian.org/~dannf/check-implicit-pointer-functions
[2]
Function `retrieve_link' implicitly converted to pointer at tar.c:270
Function `retrieve_link' implicitly converted to pointer at tar.c:270
Function `retrieve_link' implicitly converted to pointer at tar.c:270
Function `retrieve_link' implicitly converted to pointer at tar.c:270
Function `retrieve_link' implicitly converted to pointer at tar.c:270
Function `retrieve_link' implicitly converted to pointer at tar.c:270
Function `retrieve_link' implicitly converted to pointer at tar.c:270
- --- mirrordir-0.10.49-intl/src/tar.c~ 1999-11-23 01:40:09.000000000 -0700
+++ mirrordir-0.10.49-intl/src/tar.c 2005-08-31 13:58:50.000000000 -0600
@@ -30,6 +30,7 @@
#include "vfs/vfs.h"
#include "diffie/compat.h"
#include "mad.h"
+#include "hardlink.h"
int tar_block_size = 20;
- --- mirrordir-0.10.49-intl/src/hardlink.h.orig 2005-08-31
14:00:01.000000000 -0600
+++ mirrordir-0.10.49-intl/src/hardlink.h 2005-08-31 13:58:35.000000000
-0600
@@ -0,0 +1,14 @@
+#ifndef __HARDLINK_LIBRARY_H__
+#define __HARDLINK_LIBRARY_H__
+
+char *retrieve_link (void);
+
+#endif /* not __HARDLINK_LIBRARY_H__ */
+
+/*
+Local variables:
+make-backup-files: t
+version-control: t
+trim-versions-without-asking: nil
+End:
+*/
------- End of forwarded message -------
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
